1416230 - LoopUnroller.cpp: tests should be executed

Status: RESOLVED DUPLICATE of bug 1520998

(Core :: JavaScript Engine: JIT, enhancement, P5)

Description

[Sylvestre Ledru [:Sylvestre]]

Currently, the tests are not executed on for the loop unroller:
https://codecov.io/gh/marco-c/gecko-dev/src/master/js/src/jit/LoopUnroller.cpp 

Even if the feature might be disabled, we should run the tests.

Comment 1

[Nicolas B. Pierron [:nbp]]

Or we should remove the code.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Should I try to remove the code and try to find a reviewer?

Comment 3

[Nicolas B. Pierron [:nbp]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #2)
> Should I try to remove the code and try to find a reviewer?

Discussing with Jan, we do not know if we might want this code in the future and prefer to keep it around.
Maybe we can use "#if 0 — #endif" in the mean time.

Comment 4

[Jan de Mooij [:jandem]]

We're removing it in bug 1520998.