1415824 - (untestedcode-codecoverage) [meta] Write tests for files with zero coverage

Status: NEW

(Testing :: Code Coverage, enhancement)

Description

[Marco Castelluccio [:marco]]

Files from the zero coverage files report (https://marco-c.github.io/code-coverage-reports/) are often dead code and sometimes they are simply not tested.

Untested files are clearly very risky. If we are never executing them on automation, there's a high chance of unnoticed regressions.

This bug will track adding at least basic tests for these files.

Comment 1

[Steve Fink [:sfink] [:s:]]

Adding dependency on running gdb tests in automation, though I don't know how likely it is for them to learn how to do coverage builds.

Comment 2

[Alastor Wu [:alwu]]

Hi, from code coverage analysis, it show that this code has 0% test coverage [1], however, we do have a test for that [2]. Do we have a way to modify this coverage data or explicitly mark code as covered?

Thank you.

[1] https://coverage.moz.tools/#revision=latest&path=widget%2Fcocoa%2FMediaHardwareKeysEventSourceMacMediaCenter.mm&view=file
[2] https://searchfox.org/mozilla-central/source/dom/media/mediacontrol/tests/gtest/TestMediaKeysEventMediaCenter.mm

Comment 3

[Marco Castelluccio [:marco]]

(In reply to Alastor Wu [:alwu] from comment #2)

Hi, from code coverage analysis, it show that this code has 0% test coverage [1], however, we do have a test for that [2]. Do we have a way to modify this coverage data or explicitly mark code as covered?

Thank you.

[1] https://coverage.moz.tools/#revision=latest&path=widget%2Fcocoa%2FMediaHardwareKeysEventSourceMacMediaCenter.mm&view=file
[2] https://searchfox.org/mozilla-central/source/dom/media/mediacontrol/tests/gtest/TestMediaKeysEventMediaCenter.mm

We are not running tests in coverage mode on OS X, that explains it :)

See also bug 1599847, adding a skiplist is tracked in https://github.com/mozilla/code-coverage/issues/336.