1416271 - [HiDPI] Popups should close on second click

Status: NEW

(Core :: Widget: Gtk, defect)

Description

[Yuri Khan]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171109183137

Steps to reproduce:

0. Download any file, so that the Downloads button appears.
1. Right-click on the toolbar, select Customize.
2. Drag the following buttons to the toolbar if not already there: Text Encoding, Downloads, Library, Bookmarks Menu, Synced Tabs, Web Developer Tools. Drag any button to the overflow menu. Exit Customize.
3. For each button listed above, the overflow menu button, and the sandwich menu button:
3a. Click the button. Observe that a popup appears.
3b. Click the button again.


Actual results:

Except for Bookmarks Menu button, the popup disappears briefly, then appears again.

The Bookmark Menu popup closes.


Expected results:

All popups should close on second click.

The problem also affects popups displayed by add-ons, e.g. uBlock Origin.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Can you reproduce this in Safe Mode? (about:support -> Restart with add-ons disabled)

If you can still reproduce this in safe mode, please use mozregression[1] to find when this was introduced? I am unable to reproduce this on Windows and OSX.

[1] http://mozilla.github.io/mozregression/

Comment 2

[Yuri Khan]

Attachment: relevant part of mozregression log

I ran mozregression. The results are interesting.

The last “good” build was 38.0a1 of 2015-02-10, changeset 2cb22c058add, and the first “bad” was 38.0a1 of 2015-02-11, changeset 3094601af679.

I notice that all “bad” builds (popup closes and opens again) gave me the UI correctly scaled for my 192 dpi monitor, while all “good” builds (popup stays closed, or there are no popup buttons) had tiny controls and/or deformed UI (e.g. fonts assuming 192 dpi in widgets assuming 96 dpi).

On a 96 dpi monitor, the problem does not appear.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

That would point to bug 1097897. Martin, could you look in to this?

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Jan is recently working on the HiDPI issues, moving to him.

Comment 6

[Florian Quèze [:florian]]

I noticed this today too, ran mozregression, and got the same regression range as Yuri.