1416498 - Clean up the clean up code in photonpanelmultiview

Status: NEW

(Firefox :: Toolbars and Customization, enhancement, P3)

Description

[:Paolo Amadini]

The asynchronous description height workaround in bug 1392340 is the correct approach to avoid synchronous reflows when opening subviews.

Unfortunately, this causes some existing race conditions to occur, in particular because several tests do not wait for a subview to be fully shown or the panel to be fully closed. It is difficult to determine which tests cause these race conditions, as they may often occur in later tests rather than the test with the issue. They may theoretically also happen during normal usage.

To solve this, the transition clean up code should be made more robust, and possibly non-reentrant. This may require a safety timeout to prevent deadlocks while waiting for subview opening events.

Comment 1

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals