1420939 - Add an asynchronous version of the description height workaround

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P1)

Description

[:Paolo Amadini]

This prevents synchronous reflows when opening subviews of the panelmultiview element.

Comment 1

[:Gijs (he/him)]

Paolo, are you still working on this set of bugs?

Comment 2

[:Paolo Amadini]

As we discussed at the performance planning today, reducing reflows in the location bar popup may be a higher priority.

Comment 3

[:Paolo Amadini]

Attachment: Bug 1420939 - Add an asynchronous version of the description height workaround.

This prevents synchronous reflows when opening subviews. This also removes a superfluous invocation of the workaround while the panel is still hidden.

Review commit: https://reviewboard.mozilla.org/r/223692/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223692/

Comment 4

[Code Review Bot [:reviewbot]]

Comment on attachment 8954596 [details]
Bug 1420939 - Add an asynchronous version of the description height workaround.

https://reviewboard.mozilla.org/r/223692/#review229726


Code analysis found 2 defects in this patch:
 - 2 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: browser/components/customizableui/PanelMultiView.jsm:1319
(Diff revision 1)
> -        continue;
> +          continue;
> -      }
> +        }
>  
> -      items.push({ element });
> +        items.push({ element });
> -    }
> +      }
> +    }

Error: Missing semicolon. [eslint: semi]

::: browser/components/customizableui/PanelMultiView.jsm:1338
(Diff revision 1)
>      // may contain wrapping text.
> +    let measureItems = () => {
> -    for (let item of items) {
> +      for (let item of items) {
> -      item.bounds = item.element.getBoundingClientRect();
> +        item.bounds = item.element.getBoundingClientRect();
> -    }
> +      }
> +    }

Error: Missing semicolon. [eslint: semi]

Comment 5

[:Gijs (he/him)]

Comment on attachment 8954596 [details]
Bug 1420939 - Add an asynchronous version of the description height workaround.

https://reviewboard.mozilla.org/r/223692/#review230012

Besides the reviewbot nits this looks OK, assuming green try etc.

Comment 6

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8cfee8ec0d2ef8c164f30deec2b667cd9a32e38d

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b0380882e88
Add an asynchronous version of the description height workaround. r=Gijs

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2b0380882e88