1416960 - Update Debugger Frontend (11-13)

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Comment 1

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5cbca774bd52ee14a52b5f0440a0cc8d9e332501

Comment 2

[Jason Laster [:jlast]]

Attachment: patch-11-13-3.patch

Comment 3

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fc3901e1ff3904f543e383f51f4efe76d5d583c

Comment 4

[Jason Laster [:jlast]]

Attachment: patch-11-13-5.patch

Comment 5

[Julian Descottes [:jdescottes]]

A few intermittent failures on Win debug:

- in browser_dbg_keyboard-shortcuts.js and browser_dbg-sources.js on Win10x64 debug

> A promise chain failed to handle a rejection: 
> Win error 2 during operation move on file 
> C:\Users\GenericWorker\AppData\Local\Temp\tmppclgib.mozrunner\bookmarkbackups\bookmarks-2017-11-14.jsonlz4
> (The system cannot find the file specified. ) 
> - stack: null Rejection date: Tue Nov 14 2017 04:12:14 GMT+0000 (Coordinated Universal Time) - false == true

- in browser_dbg_keyboard-shortcuts.js on Win7 debug

> Assertion failure: js::CheckGrayMarkingState(mJSRuntime), at z:/build/build/src/xpcom/base/CycleCollectedJSRuntime.cpp
> 04:10:05     INFO -  GECKO(2888) | Assertion failure: js::CheckGrayMarkingState(mJSRuntime), at z:/build/build/src/xpcom/base/CycleCollectedJSRuntime.cpp:1216
> 04:10:05     INFO -  GECKO(2888) | #01: mozilla::CycleCollectedJSRuntime::CheckGrayBits() [xpcom/base/CycleCollectedJSRuntime.cpp:1209]
> 04:10:05     INFO -  GECKO(2888) | #02: nsCycleCollector::Collect(ccType,js::SliceBudget &,nsICycleCollectorListener *,bool) [xpcom/base/nsCycleCollector.cpp:3777]
> 04:10:05     INFO -  GECKO(2888) | #03: nsCycleCollector_collectSlice(js::SliceBudget &,bool) [xpcom/base/nsCycleCollector.cpp:4331]
> 04:10:05     INFO -  GECKO(2888) | #04: nsJSContext::RunCycleCollectorSlice(mozilla::TimeStamp) [dom/base/nsJSEnvironment.cpp:1561]
> 04:10:05     INFO -  GECKO(2888) | #05: CCRunnerFired [dom/base/nsJSEnvironment.cpp:1958]
> 04:10:05     INFO -  GECKO(2888) | #06: std::_Func_impl_no_alloc<bool (*)(mozilla::TimeStamp),bool,mozilla::TimeStamp>::_Do_call(mozilla::TimeStamp &&) [vs2017_15.4.2/VC/include/functional:299]
> 04:10:05     INFO -  GECKO(2888) | #07: std::_Func_class<bool,mozilla::TimeStamp>::operator()(mozilla::TimeStamp) [vs2017_15.4.2/VC/include/functional:351]
> 04:10:05     INFO -  GECKO(2888) | #08: mozilla::IdleTaskRunner::Run() [xpcom/threads/IdleTaskRunner.cpp:66]
> 04:10:05     INFO -  GECKO(2888) | #09: nsThread::ProcessNextEvent(bool,bool *) [xpcom/threads/nsThread.cpp:1038]
> 04:10:05     INFO -  GECKO(2888) | #10: NS_ProcessNextEvent(nsIThread *,bool) [xpcom/threads/nsThreadUtils.cpp:513]
> 04:10:05     INFO -  GECKO(2888) | #11: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate *) [ipc/glue/MessagePump.cpp:97]
> 04:10:05     INFO -  GECKO(2888) | #12: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:326]
> 04:10:05     INFO -  GECKO(2888) | #13: MessageLoop::RunHandler() [ipc/chromium/src/base/message_loop.cc:320]
> 04:10:05     INFO -  GECKO(2888) | #14: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:300]
> 04:10:05     INFO -  GECKO(2888) | #15: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:161]
> 04:10:05     INFO -  GECKO(2888) | #16: nsAppShell::Run() [widget/windows/nsAppShell.cpp:230]
> 04:10:05     INFO -  GECKO(2888) | #17: nsAppStartup::Run() [toolkit/components/startup/nsAppStartup.cpp:289]
> 04:10:05     INFO -  GECKO(2888) | #18: XREMain::XRE_mainRun() [toolkit/xre/nsAppRunner.cpp:4685]
> 04:10:05     INFO -  GECKO(2888) | #19: XREMain::XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [toolkit/xre/nsAppRunner.cpp:4847]
> 04:10:05     INFO -  GECKO(2888) | #20: XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [toolkit/xre/nsAppRunner.cpp:4942]
> 04:10:05     INFO -  GECKO(2888) | #21: mozilla::BootstrapImpl::XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [toolkit/xre/Bootstrap.cpp:49]
> 04:10:05     INFO -  GECKO(2888) | #22: do_main [browser/app/nsBrowserApp.cpp:232]
> 04:10:05     INFO -  GECKO(2888) | #23: NS_internal_main(int,char * *,char * *) [browser/app/nsBrowserApp.cpp:304]
> 04:10:05     INFO -  GECKO(2888) | #24: wmain [toolkit/xre/nsWindowsWMain.cpp:114]
> 04:10:05     INFO -  GECKO(2888) | #25: __scrt_common_main_seh [f:/dd/vctools/crt/vcstartup/src/startup/exe_common.inl:283]
> 04:10:05     INFO -  GECKO(2888) | #26: kernel32.dll + 0x53c45
> 04:10:05     INFO -  GECKO(2888) | #27: ntdll.dll + 0x637f5
> 04:10:05     INFO -  GECKO(2888) | #28: ntdll.dll + 0x637c8

Comment 6

[Julian Descottes [:jdescottes]]

I doubt any of those are really debugger related. I found various intermittents logged for both of those issues:
See discussions in Bug 1399866 and Bug 1404253 comment 4.

Comment 7

[Julian Descottes [:jdescottes]]

Comment on attachment 8928059 [details] [diff] [review]
patch-11-13-5.patch

LGTM

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c38f0fd0af3
Update Debugger frontend (11-13). r=jdescottes

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6c38f0fd0af3