1417117 - Unusable typing latency in Awesomebar

Status: RESOLVED FIXED

(Firefox for iOS :: Menu and Toolbar, defect, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Typing in the awesomebar has become almost completely unusable on my iPhone 6 Plus, with extremely frequent lags, often of a second or longer (Firefox for iOS 10.1 (7709)).  It seemed fine a week or two ago.
  
I have upgraded from iOS 11.0.3 to iOS 11.1.1 in the last week, but I've also gotten new Firefox for iOS updates in that time, so I suspect some combination of those things are involved.  Also potentially relevant is that I use Firefox sync and have a large old synced profile.  

Another interesting data point: Firefox Focus 3.10.1 has no such problem.  I'll probably have to switch to Focus until this is fixed, as this problem makes it super unpleasant to use.  :-(

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

This seems likely a DUP of 1169322 to some degree, with the possible exception that it seems like it has gotten MUCH worse in the last small number of weeks, and that bug was filed years ago.

Comment 2

[:garvan]

Attachment: Pull request

The SearchLoader.swift code structure is this:

// deferred is the main db query
deferred.uponQueue(DispatchQueue.main) { result in
< snip (code that uses cursors to access db on main thread) >
 self.urlBar.setAutocompleteSuggestion(completion)
<snip>                                            
}

And it should be:

// deferred is the main db query
deferred.upon { result in // run on background thread
< snip (code that uses cursors to access db on main thread) >
DispatchQueue.main.async {
 self.urlBar.setAutocompleteSuggestion(completion)  
}
<snip>                                            
}

The DB queries are slow and also need to be fixed, but hitting disk is a perf-unbounded op.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8931734 [details] [review]
Pull request

I think this is good but further follow-ups are worthwhile.

Comment 4

[Richard Newman [:rnewman]]

btw, I've been seeing the exact same behavior as Dan… but only on the release channel on my iPad.

Comment 5

[Richard Newman [:rnewman]]

Tracking the next release = P1, I think.

Comment 6

[:garvan]

I added Richards comments to this overall search performance bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1169322#c6

The patch here should fix the typing latency, but search performance still needs to be addressed.

Comment 7

[:garvan]

Attachment: Pull request

This is a cleaned up patch.

I want to add a test case for this, but I don't have it ready yet.

Comment 8

[:garvan]

Added follow up for test cases: https://bugzilla.mozilla.org/show_bug.cgi?id=1422976

Comment 9

[:garvan]

Justin adding you to cc list as you were interested in following this

Comment 10

[Richard Newman [:rnewman]]

Comment on attachment 8934297 [details] [review]
Pull request

Test before uplift!

Comment 11

[:garvan]

Landed master and 10.x.