stylo: serialization of rule list in group rules is different than Gecko

RESOLVED FIXED in Firefox 59

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
5 days ago
3 days ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Details

Attachments

(1 attachment)

If we have a rule like:
> @media screen { div { color: white; } }

Gecko (as well as Blink) serializes it as:
> @media screen {
>   div { color: white; }
> }
while Stylo serializes it as
> @media screen { div { color: white; } }

Although the serialization is not speced anywhere at the moment, I think the way Gecko and Blink currently do makes sense, and we should change Stylo to do so as well.

It causes failures in layout/style/test/chrome/test_chrome_only_media_queries.html when I tried to enable stylo on chrome by default.
Created attachment 8928292 [details] [review]
Servo PR
(In reply to Xidorn Quan [:xidorn] UTC-8 (less responsive Nov 5 ~ Dec 16) from comment #0)
> It causes failures in
> layout/style/test/chrome/test_chrome_only_media_queries.html when I tried to
> enable stylo on chrome by default.

Whoops, that happens to me for writing tests the lazy way ;)
https://hg.mozilla.org/integration/autoland/rev/311a0f15026f
Assignee: nobody → xidorn+moz
https://hg.mozilla.org/mozilla-central/rev/311a0f15026f
Status: NEW → RESOLVED
Last Resolved: 4 days ago
Resolution: --- → FIXED
status-firefox57: --- → wontfix
status-firefox58: --- → wontfix
status-firefox59: affected → fixed
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.