1417207 - stylo: serialization of rule list in group rules is different than Gecko

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+10]

If we have a rule like:
> @media screen { div { color: white; } }

Gecko (as well as Blink) serializes it as:
> @media screen {
>   div { color: white; }
> }
while Stylo serializes it as
> @media screen { div { color: white; } }

Although the serialization is not speced anywhere at the moment, I think the way Gecko and Blink currently do makes sense, and we should change Stylo to do so as well.

It causes failures in layout/style/test/chrome/test_chrome_only_media_queries.html when I tried to enable stylo on chrome by default.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Servo PR

Comment 2

[Emilio Cobos Álvarez (:emilio)]

(In reply to Xidorn Quan [:xidorn] UTC-8 (less responsive Nov 5 ~ Dec 16) from comment #0)
> It causes failures in
> layout/style/test/chrome/test_chrome_only_media_queries.html when I tried to
> enable stylo on chrome by default.

Whoops, that happens to me for writing tests the lazy way ;)

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/autoland/rev/311a0f15026f

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/mozilla-central/rev/311a0f15026f