1417272 - The "Send Tab to Device" page action can be disabled in the page action menu but enabled in the urlbar

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Drew Willcoxon :adw]

If you open a page that's not sendable via Sync (about:about for example), the Send Tab to Device menu item in the page action menu will be disabled.  But if you also add that action to the urlbar, its button there will not be disabled.  The menu item is disabled here: https://dxr.mozilla.org/mozilla-central/rev/fc194660762d1b92e1679d860a8bf41116d0f54f/browser/base/content/browser-pageActions.js#962

Only the node in the menu is disabled, not the one in the urlbar (if present).  But what should actually happen now (probably) is to call PageActions.actionForID("sendToDevice").setDisabled(window), now that we have that ability.  That will automatically disable both nodes for that window.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1417272 - The "Send Tab to Device" page action can be disabled in the page action menu but enabled in the urlbar.

Review commit: https://reviewboard.mozilla.org/r/199924/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199924/

Comment 2

[Drew Willcoxon :adw]

This replaces the manual setting of the disabled attribute on the panel button (and only the panel button, not the urlbar button) with an onLocationChange handler and action.setDisabled().

Comment 3

[:Gijs (he/him)]

Comment on attachment 8928681 [details]
Bug 1417272 - The "Send Tab to Device" page action can be disabled in the page action menu but enabled in the urlbar.

https://reviewboard.mozilla.org/r/199924/#review205408

Great, thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bf259a96c49
The "Send Tab to Device" page action can be disabled in the page action menu but enabled in the urlbar. r=Gijs

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/6bf259a96c49