1417297 - Convert gmp-clearkey to use Chromium ContentDecryptionModule_9 interface

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, enhancement, P3)

Description

[James Cheng[:JamesCheng]]

I would like to convert the interface once the new Widevine CDM version 9 releases.

We will start to drop ContentDecryptionModule_8 and this is once of the work.

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1417297 - Part1 - Convert gmp-clearkey to use Chromium ContentDecryptionModule_9 interface.

1. Make ClearKeyCDM inherits cdm::ContentDecryptionModule_9
2. Pass cdm::Host_9 instance instead of cdm::Host8
3. Modify the manifest to 1.4.9

Review commit: https://reviewboard.mozilla.org/r/202410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202410/

Comment 2

[James Cheng[:JamesCheng]]

Attachment: Bug 1417297 - Part2 - Convert fake-cdm to use Chromium ContentDecryptionModule_9 interface.

Review commit: https://reviewboard.mozilla.org/r/202412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202412/

Comment 3

[James Cheng[:JamesCheng]]

Push Try to know if I forgot to modify anything....

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dc8ec32b55e420fc94466a29649b8a99f7bf161

Comment 4

[James Cheng[:JamesCheng]]

I've checked the latest chromium CDM.h. There is nothing change.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8931264 [details]
Bug 1417297 - Part1 - Convert gmp-clearkey to use Chromium ContentDecryptionModule_9 interface.

https://reviewboard.mozilla.org/r/202410/#review208312

Please also check that these changes don't regress the EME web platform tests.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8931265 [details]
Bug 1417297 - Part2 - Convert fake-cdm to use Chromium ContentDecryptionModule_9 interface.

https://reviewboard.mozilla.org/r/202412/#review208314

Comment 7

[James Cheng[:JamesCheng]]

(In reply to Chris Pearce (:cpearce) from comment #5)
> Comment on attachment 8931264 [details]
> Bug 1417297 - Part1 - Convert gmp-clearkey to use Chromium
> ContentDecryptionModule_9 interface.
> 
> https://reviewboard.mozilla.org/r/202410/#review208312
> 
> Please also check that these changes don't regress the EME web platform
> tests.

Thanks for review,

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dc8ec32b55e420fc94466a29649b8a99f7bf161

WPT tests work with these patches.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88b8a5b2f668
Part1 - Convert gmp-clearkey to use Chromium ContentDecryptionModule_9 interface. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/f2f0569649db
Part2 - Convert fake-cdm to use Chromium ContentDecryptionModule_9 interface. r=cpearce

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/88b8a5b2f668
https://hg.mozilla.org/mozilla-central/rev/f2f0569649db