1516669 - Convert gmp-clearkey to use Chromium ContentDecryptionModule_10 interface

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, enhancement, P3)

Description

[Bryce Seager van Dyk (:bryce)]

Doing this would keep our widevine and clearkey interfaces in step, which is desirable to enable us to test the interface. It also avoids the scenario where we bump the widevine cdm headers and the interface clearkey is supporting is no longer in the headers (a medium term risk).

See bug 1417297 for the last time this was done.

Comment 1

[Bryce Seager van Dyk (:bryce)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ed68ea53e62d724638cb4bd20176e8eddc85cd8

Comment 2

[Bryce Seager van Dyk (:bryce)]

Attachment: Bug 1516669 - Update gmp-clearkey to use CDM10 interface. r?cpearce

Not much changed in the interface:
- CDM initialization takes a use hardware codecs arg, we pipe this through, but
  don't do anything more with it in the clearkey CDM.
- The CDM should call the hosts OnInitialized() when it's initialized. This is
  done is now done in the clearkey CDM once the session management is ready, as
  that is the last thing done during init.

Aside from the above, it's just updating interface usage. While the new CDM
interface adds support for different encryption schemes, this is not handled
here and will be done in follow up bug 1516673.

Comment 3

[Bryce Seager van Dyk (:bryce)]

Attachment: Bug 1516669 - Check init value of clearkey WMF decoder for failure. r?cpearce

We weren't checking this value and it was causing compiler warnings. Instead
this change means we check the value and log an error if init has failed.

Depends on D15518

Comment 4

[Bryce Seager van Dyk (:bryce)]

Attachment: Bug 1516669 - Update fake-cdm to use CDM10 interface. r?cpearce

Depends on D15519

Comment 5

[Bryce Seager van Dyk (:bryce)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff016b00f8abd99849b835aa488dc6af3cfb27ab

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b430ac03ce29
Update gmp-clearkey to use CDM10 interface. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/bd1e99a6325a
Check init value of clearkey WMF decoder for failure. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/041c4580aa6f
Update fake-cdm to use CDM10 interface. r=cpearce

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b430ac03ce29
https://hg.mozilla.org/mozilla-central/rev/bd1e99a6325a
https://hg.mozilla.org/mozilla-central/rev/041c4580aa6f