Convert gmp-clearkey to use Chromium ContentDecryptionModule_10 interface

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: bryce, Assigned: bryce)

Tracking

(Blocks 1 bug)

unspecified
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(3 attachments)

Assignee

Description

6 months ago
Doing this would keep our widevine and clearkey interfaces in step, which is desirable to enable us to test the interface. It also avoids the scenario where we bump the widevine cdm headers and the interface clearkey is supporting is no longer in the headers (a medium term risk).

See bug 1417297 for the last time this was done.
Assignee

Updated

6 months ago
Blocks: 1516673
Assignee

Comment 2

6 months ago
Not much changed in the interface:
- CDM initialization takes a use hardware codecs arg, we pipe this through, but
  don't do anything more with it in the clearkey CDM.
- The CDM should call the hosts OnInitialized() when it's initialized. This is
  done is now done in the clearkey CDM once the session management is ready, as
  that is the last thing done during init.

Aside from the above, it's just updating interface usage. While the new CDM
interface adds support for different encryption schemes, this is not handled
here and will be done in follow up bug 1516673.
Assignee

Comment 3

6 months ago
We weren't checking this value and it was causing compiler warnings. Instead
this change means we check the value and log an error if init has failed.

Depends on D15518

Comment 6

5 months ago
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b430ac03ce29
Update gmp-clearkey to use CDM10 interface. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/bd1e99a6325a
Check init value of clearkey WMF decoder for failure. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/041c4580aa6f
Update fake-cdm to use CDM10 interface. r=cpearce

Comment 7

5 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.