Closed Bug 1417334 Opened 3 years ago Closed 3 years ago

Add default64.png and default128.png to the Linux package

Categories

(Thunderbird :: Theme, enhancement)

All
Linux
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 59.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Like Fx in bug 1415014 we don't package 64px and 128pc icons to use as HiDPI icons.
Attached patch iconsToGtk.patchSplinter Review
Add the 64px and 128px icons.

I touched a lot of icons because I optimized them (made them smaller). We had also the 48px icon two times in our tree. I removed the icon48.png and use now the mailicon48.png.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8928442 - Flags: review?(acelists)
Comment on attachment 8928442 [details] [diff] [review]
iconsToGtk.patch

Review of attachment 8928442 [details] [diff] [review]:
-----------------------------------------------------------------

How could I test this on Linux?

::: mail/installer/allowed-dupes.mn
@@ +16,5 @@
>  chrome/classic/skin/classic/messenger/icons/security.svg
>  chrome/classic/skin/classic/messenger/icons/spelling.svg
>  chrome/classic/skin/classic/messenger/icons/tag.svg
>  chrome/messenger/content/branding/icon48.png
> +chrome/messenger/content/branding/icon64.png

Is this needed? Didn't you remove some duplication so don't you actually need to remove the icon48 from here, not add icon64? What does this file allowed-dupes.mn do?
The removal is only in the tree. But in the package there are two same files, the chrome/messenger/content/branding/icon64.png and the chrome/icons/default/default64.png and allowed-dupes.mn is to allow this dupes in the package.
Comment on attachment 8928442 [details] [diff] [review]
iconsToGtk.patch

Review of attachment 8928442 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, seems to work. The new icons appear in bin/dist/bin/chrome/icons/default .
Attachment #8928442 - Flags: review?(acelists) → review+
Thanks
Keywords: checkin-needed
Blocks: 1414881
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/6680a5309dda
Add default64.png and default128.png to the Linux package. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 59.0
You need to log in before you can comment on or make changes to this bug.