1417356 - stylo: Some web extension xpcshell tests on Android are failure with stylo

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/logviewer.html#?job_id=144885429&repo=try&lineNumber=1717

xpcshell doesn't have Java thread...

Comment 1

[Makoto Kato [:m_kato]]

maybe, this is a regression by bug 1403690

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1417356 - xpcshell doesn't have Java thread.

This is a regression by bug 1403690.  After landing this, some xpcshell tests
cause crash with stylo.

mozilla::java::GeckoAppShell::GetShowPasswordSetting doesn't work on xpcshell
test.  If JNI isn't available such as xpcshell, we shouldn't use this method.

Review commit: https://reviewboard.mozilla.org/r/200080/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200080/

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8928805 [details]
Bug 1417356 - xpcshell doesn't have Java thread.

https://reviewboard.mozilla.org/r/200080/#review205526

::: widget/android/nsLookAndFeel.cpp:518
(Diff revision 1)
> -            mShowPassword = java::GeckoAppShell::GetShowPasswordSetting();
> +            mShowPassword = jni::IsAvailable() ?
> +                                java::GeckoAppShell::GetShowPasswordSetting() :
> +                                false; // xpcshell case

How about this?

    mShowPassword = jni::IsAvailable() && java::GeckoAppShell::GetShowPasswordSetting();

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/144f04d80cf1
xpcshell doesn't have Java thread. r=jchen

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/144f04d80cf1