stylo: Some web extension xpcshell tests on Android are failure with stylo

RESOLVED FIXED in Firefox 59

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Details

Attachments

(1 attachment)

maybe, this is a regression by bug 1403690
Assignee: nobody → m_kato
Blocks: 1403690
Comment on attachment 8928805 [details]
Bug 1417356 - xpcshell doesn't have Java thread.

https://reviewboard.mozilla.org/r/200080/#review205526

::: widget/android/nsLookAndFeel.cpp:518
(Diff revision 1)
> -            mShowPassword = java::GeckoAppShell::GetShowPasswordSetting();
> +            mShowPassword = jni::IsAvailable() ?
> +                                java::GeckoAppShell::GetShowPasswordSetting() :
> +                                false; // xpcshell case

How about this?

    mShowPassword = jni::IsAvailable() && java::GeckoAppShell::GetShowPasswordSetting();
Attachment #8928805 - Flags: review?(nchen) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/144f04d80cf1
xpcshell doesn't have Java thread. r=jchen
https://hg.mozilla.org/mozilla-central/rev/144f04d80cf1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.