1417512 - Performance Tools to use ES6 Classes, prop-types and react-dom-factories

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

There are a number of reasons for this:

1. We need to have the modules available for code from devtools-core, which uses them.
2. It begins the process of getting rid of React deprecation warnings.
3. It prepares us to upgrade to React 16.

Versioning info from devtools-core github repo:

"prop-types": "^15.6.0"
"react-dom-factories": "^1.0.2"

--------------

This patch also includes some changes inside `devtools/client/dom/content/components/`. This is part of an effort to spread these patches out more evenly.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1417512 - Performance Tools to ES6 Classes, prop-types and react-dom-factories

Review commit: https://reviewboard.mozilla.org/r/199840/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199840/

Comment 2

[Greg Tatum [:gregtatum]]

Comment on attachment 8928613 [details]
Bug 1417512 - Performance Tools to ES6 Classes, prop-types and react-dom-factories

https://reviewboard.mozilla.org/r/199840/#review204964

Looks good to me! I gave the binary a test run, just to make sure all the event handlers were bound, and nothing seemed to regress.

Comment 3

[Greg Tatum [:gregtatum]]

Comment on attachment 8928613 [details]
Bug 1417512 - Performance Tools to ES6 Classes, prop-types and react-dom-factories

https://reviewboard.mozilla.org/r/199840/#review204966

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f646802903a9
Performance Tools to ES6 Classes, prop-types and react-dom-factories r=gregtatum

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f646802903a9