Closed Bug 1417512 Opened 3 years ago Closed 3 years ago
Performance Tools to use ES6 Classes, prop-types and react-dom-factories
59 bytes, text/x-review-board-request
There are a number of reasons for this: 1. We need to have the modules available for code from devtools-core, which uses them. 2. It begins the process of getting rid of React deprecation warnings. 3. It prepares us to upgrade to React 16. Versioning info from devtools-core github repo: "prop-types": "^15.6.0" "react-dom-factories": "^1.0.2" -------------- This patch also includes some changes inside `devtools/client/dom/content/components/`. This is part of an effort to spread these patches out more evenly.
3 years ago
Status: NEW → ASSIGNED
Comment on attachment 8928613 [details] Bug 1417512 - Performance Tools to ES6 Classes, prop-types and react-dom-factories https://reviewboard.mozilla.org/r/199840/#review204964 Looks good to me! I gave the binary a test run, just to make sure all the event handlers were bound, and nothing seemed to regress.
Comment on attachment 8928613 [details] Bug 1417512 - Performance Tools to ES6 Classes, prop-types and react-dom-factories https://reviewboard.mozilla.org/r/199840/#review204966
Attachment #8928613 - Flags: review?(gtatum) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f646802903a9 Performance Tools to ES6 Classes, prop-types and react-dom-factories r=gregtatum
You need to log in before you can comment on or make changes to this bug.