Closed Bug 1417512 Opened 2 years ago Closed 2 years ago

Performance Tools to use ES6 Classes, prop-types and react-dom-factories

Categories

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

enhancement

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: miker, Assigned: miker)

References

Details

Attachments

(1 file)

There are a number of reasons for this:

1. We need to have the modules available for code from devtools-core, which uses them.
2. It begins the process of getting rid of React deprecation warnings.
3. It prepares us to upgrade to React 16.

Versioning info from devtools-core github repo:

"prop-types": "^15.6.0"
"react-dom-factories": "^1.0.2"

--------------

This patch also includes some changes inside `devtools/client/dom/content/components/`. This is part of an effort to spread these patches out more evenly.
Status: NEW → ASSIGNED
Comment on attachment 8928613 [details]
Bug 1417512 - Performance Tools to ES6 Classes, prop-types and react-dom-factories

https://reviewboard.mozilla.org/r/199840/#review204964

Looks good to me! I gave the binary a test run, just to make sure all the event handlers were bound, and nothing seemed to regress.
Comment on attachment 8928613 [details]
Bug 1417512 - Performance Tools to ES6 Classes, prop-types and react-dom-factories

https://reviewboard.mozilla.org/r/199840/#review204966
Attachment #8928613 - Flags: review?(gtatum) → review+
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f646802903a9
Performance Tools to ES6 Classes, prop-types and react-dom-factories r=gregtatum
https://hg.mozilla.org/mozilla-central/rev/f646802903a9
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.