1417615 - [Layout] Content truncated when printing a page containing a CSS grid with large row

Status: RESOLVED FIXED

(Core :: Printing: Output, defect, P3)

Description

[Alex Shafer]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171112125346

Steps to reproduce:

1. Create/load a page containing a CSS grid with a very large row
2. Print the page


Actual results:

The large row will be shifted onto its own page in the printed document, and content will be truncated if larger than the page


Expected results:

Content should be split between pages regardless of its position in the CSS grid (Chrome does this correctly)

Comment 1

[Jonathan Watt [:jwatt]]

Could you attach a simple testcase that demonstrates the issue?

Comment 2

[Alex Shafer]

Attachment: gridprinttest.html - Source for simple test case

Comment 3

[Alex Shafer]

Attachment: firefox_gridprinttest.html.pdf - Result of printing the test case with firefox showing the bug

Comment 4

[Alex Shafer]

Attachment: chrome_gridprinttest.pdf - Result of printing the test case with chrome showing the expected behavior

Comment 5

[Alex Shafer]

Files have been attached including a test case and actual/expected results.

Comment 12

[Sean Voisen (:svoisen)]

Pocket content, such as this page, appears to suffer from this bug: https://getpocket.com/explore/item/how-to-make-kombucha-tea-at-home?utm_source=pocket-newtab

Comment 15

[Mats Palmgren (inactive)]

Bug 1640197 / bug 1665214 should fix this when we enable it.

Comment 16

[Daniel Holbert [:dholbert]]

(In reply to Mats Palmgren (inactive) from comment #15)

Bug 1640197 / bug 1665214 should fix this when we enable it.

Update: this is now indeed fixed via that approach (tall-grid-row content should no longer be truncated/lost at pagebreaks).

Having said that, things still aren't perfect, since we'll potentially end up "slicing" text in half at a pagebreak, and that's not-great; bug 1759926 is filed to track that general problem (though we don't have a great solution for that at this point).

I think we can close this bug as fixed-by bug 1640197 and bug 1665214, though.