1417826 - Add MOZ_MACBUNDLE_ID=nightly to the nightly configure

Status: VERIFIED FIXED

(Firefox Build System :: General, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

Because MOZ_APP_DISPLAYNAME will be renamed with a space "Firefox Nightly", we want to keep MOZ_MACBUNDLE_ID to be "nightly" to avoid bug 1404956

The patch won't land until bug 1378834 has been verified.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1417826 - Fix the MOZ_MACBUNDLE_ID id

This will preserve the id and avoid some regressions in addons.

Review commit: https://reviewboard.mozilla.org/r/200240/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200240/

Comment 2

[Stephen A Pohl [:spohl]]

Comment on attachment 8928906 [details]
Bug 1417826 - Fix the MOZ_MACBUNDLE_ID id

https://reviewboard.mozilla.org/r/200240/#review205444

You probably want to get this reviewed by someone in "Build Config"[1].

[1] https://wiki.mozilla.org/Modules/All#Build_Config

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8928906 [details]
Bug 1417826 - Fix the MOZ_MACBUNDLE_ID id

https://reviewboard.mozilla.org/r/200240/#review208824

::: browser/branding/nightly/configure.sh:6
(Diff revision 1)
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  MOZ_APP_DISPLAYNAME=FirefoxNightly
> +MOZ_MACBUNDLE_ID=nightly

The current id, as per the derivation in old-configure.in, would be firefoxnightly, not nightly, so this doesn't preserve the current id.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8928906 [details]
Bug 1417826 - Fix the MOZ_MACBUNDLE_ID id

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200240/diff/1-2/

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Sorry, I realized that I didn't land it...

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/cd7926a8269c
Fix the MOZ_MACBUNDLE_ID id r=glandium a=update-fix

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cd7926a8269c

Comment 8

[bintoro]

What's going on here? The final patch hardcodes the bundle ID as "org.mozilla.firefoxnightly", which is precisely the situation this bug was created to avoid.

Now that the patch has landed, it has reintroduced bug 1404956 as predicted in the initial comment.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

This bug was about keep the same bundle ID for Mac.
As Mike said in comment #3, it is supposed to be firefoxnightly (the changed that Aryx landed for me yesterday).

This is based on this patch:
https://hg.mozilla.org/mozilla-central/rev/7148babfe2ab
which landed a month ago.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

oh, ok, you mean that comment #3 from Mike was incorrect?

Comment 11

[bintoro]

(In reply to Sylvestre Ledru [:sylvestre] from comment #10)
> oh, ok, you mean that comment #3 from Mike was incorrect?

It looks that way, unless the intent really was to change the bundle ID from what it's historically been.

Previously, the bundle ID was "org.mozilla.nightly". This bug was created to keep it that way (as indicated by the bug summary), but either the plans changed or things got mixed up along the way.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

It wasn't the intent.
I just doubled check and it is was indeed org.mozilla.nightly
(found with osascript -e 'id of app "FirefoxNightly"')

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/9e3cb9f98118
Backed out changeset cd7926a8269c. It was changing the bundle id on mac r=me a=update-fix

Comment 14

[Sylvestre Ledru [:Sylvestre]]

The last nightly is back as org.mozilla.firefox

Please let me know if you see any issue.

Comment 15

[bintoro]

Confirmed as fixed. Thanks!