Closed Bug 1417826 Opened 2 years ago Closed 2 years ago

Add MOZ_MACBUNDLE_ID=nightly to the nightly configure

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

VERIFIED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 obsolete file)

Because MOZ_APP_DISPLAYNAME will be renamed with a space "Firefox Nightly", we want to keep MOZ_MACBUNDLE_ID to be "nightly" to avoid bug 1404956

The patch won't land until bug 1378834 has been verified.
Comment on attachment 8928906 [details]
Bug 1417826 - Fix the MOZ_MACBUNDLE_ID id

https://reviewboard.mozilla.org/r/200240/#review205444

You probably want to get this reviewed by someone in "Build Config"[1].

[1] https://wiki.mozilla.org/Modules/All#Build_Config
Attachment #8928906 - Flags: review?(spohl.mozilla.bugs)
Attachment #8928906 - Flags: review?(mh+mozilla)
Comment on attachment 8928906 [details]
Bug 1417826 - Fix the MOZ_MACBUNDLE_ID id

https://reviewboard.mozilla.org/r/200240/#review208824

::: browser/branding/nightly/configure.sh:6
(Diff revision 1)
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  MOZ_APP_DISPLAYNAME=FirefoxNightly
> +MOZ_MACBUNDLE_ID=nightly

The current id, as per the derivation in old-configure.in, would be firefoxnightly, not nightly, so this doesn't preserve the current id.
Attachment #8928906 - Flags: review?(mh+mozilla)
Assignee: nobody → sledru
Sorry, I realized that I didn't land it...
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/cd7926a8269c
Fix the MOZ_MACBUNDLE_ID id r=glandium a=update-fix
https://hg.mozilla.org/mozilla-central/rev/cd7926a8269c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
What's going on here? The final patch hardcodes the bundle ID as "org.mozilla.firefoxnightly", which is precisely the situation this bug was created to avoid.

Now that the patch has landed, it has reintroduced bug 1404956 as predicted in the initial comment.
This bug was about keep the same bundle ID for Mac.
As Mike said in comment #3, it is supposed to be firefoxnightly (the changed that Aryx landed for me yesterday).

This is based on this patch:
https://hg.mozilla.org/mozilla-central/rev/7148babfe2ab
which landed a month ago.
oh, ok, you mean that comment #3 from Mike was incorrect?
Flags: needinfo?(kalle)
(In reply to Sylvestre Ledru [:sylvestre] from comment #10)
> oh, ok, you mean that comment #3 from Mike was incorrect?

It looks that way, unless the intent really was to change the bundle ID from what it's historically been.

Previously, the bundle ID was "org.mozilla.nightly". This bug was created to keep it that way (as indicated by the bug summary), but either the plans changed or things got mixed up along the way.
Flags: needinfo?(kalle)
It wasn't the intent.
I just doubled check and it is was indeed org.mozilla.nightly
(found with osascript -e 'id of app "FirefoxNightly"')
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/9e3cb9f98118
Backed out changeset cd7926a8269c. It was changing the bundle id on mac r=me a=update-fix
The last nightly is back as org.mozilla.firefox

Please let me know if you see any issue.
Status: RESOLVED → VERIFIED
Confirmed as fixed. Thanks!
Attachment #8928906 - Flags: review?(mh+mozilla)
Attachment #8928906 - Attachment is obsolete: true
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.