Closed Bug 1417918 Opened 2 years ago Closed 2 years ago
Folder Bookmark Management: Keyword not saved when parent folder is changed as well
59 bytes, text/x-review-board-request
Environment: Device: Nexus 5 (Android 6.0.1); Build: Nightly 59.0a1 (2017-11-16); Steps to reproduce: 1. perform a long tap on a bookmark added from Bookmark panel; 2. Choose Edit; 3. Add a keyword; 4. Tap on Parent Folder option and change to move the bookmark in a folder or add a new one; 5. Tap on Save. Expected result: The Keyword is added to the bookmark. Actual result: After the user is changing the Parent Folder, the page with the options Name, Location, Parent folder and keyword is displayed again, but the keyword added at step 3 is missing. Notes: seems like bug 1374251.
Right, the patch from bug 1374251 looks clear enough and I overlooked that when adding keyword editing in.
Comment on attachment 8929529 [details] Bug 1417918 - Save current keyword before navigating to SelectFolderFragment. https://reviewboard.mozilla.org/r/200804/#review207444
Attachment #8929529 - Flags: review?(topwu.tw) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/345fd2d2bf80 Save current keyword before navigating to SelectFolderFragment. r=jwu
Comment on attachment 8929529 [details] Bug 1417918 - Save current keyword before navigating to SelectFolderFragment. Approval Request Comment [Feature/Bug causing the regression]: Bug 1405215 [User impact if declined]: When editing a bookmark, changes made to the keyword will be forgotten if the user also visits the dialogue to choose a different parent folder. [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: Tested locally. [Needs manual test from QE? If yes, steps to reproduce]: See comment 0. [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: No. [Why is the change risky/not risky?]: Same change was done bug 1374251 for the bookmark/folder title. [String changes made/needed]: none
Attachment #8929529 - Flags: approval-mozilla-beta?
Comment on attachment 8929529 [details] Bug 1417918 - Save current keyword before navigating to SelectFolderFragment. Fix a bookmark editing regression. Beta58+.
Attachment #8929529 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on latest Nightly build (59.0a1 - 27/2017). Device: Honor 8 (Android 7.0), Nexus 5 (Android 6.0.1). Keyword added is still displayed after the parent folder is changed.
Verified as fixed on Beta 58.0b7. Device: Huawei MediaPad M2 (Android 5.1.1)
You need to log in before you can comment on or make changes to this bug.