Closed Bug 1417940 Opened 2 years ago Closed 2 years ago

Change various instances of manually calling getService to use Services.jsm in toolkit/

Categories

(Toolkit :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I'm working on transition all of toolkit to use Services.jsm where possible (as found by the ESLint mozilla/use-services rule).

I have a patch for changing about half the remaining instances in toolkit/ to use Services.jsm, which I think is a reasonable size to land now, and then we can land the rest later.
Blocks: 1417944
Comment on attachment 8929027 [details]
Bug 1417940 - Change various instances of manually calling getService to use Services.jsm in toolkit/.

https://reviewboard.mozilla.org/r/200346/#review205610
Attachment #8929027 - Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c2f807e23b5
Change various instances of manually calling getService to use Services.jsm in toolkit/. r=mossop
Blocks: 1418959
I've undone the change that caused the leak as I don't know the reason for it - I've filed bug 1418959 as a follow-up.
Flags: needinfo?(standard8)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3cffb9b8872b
Change various instances of manually calling getService to use Services.jsm in toolkit/. r=mossop
https://hg.mozilla.org/mozilla-central/rev/3cffb9b8872b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.