Closed Bug 1417940 Opened 2 years ago Closed 2 years ago
Change various instances of manually calling get
Service to use Services .jsm in toolkit/
Bug 1417940 - Change various instances of manually calling getService to use Services.jsm in toolkit/.
59 bytes, text/x-review-board-request
I'm working on transition all of toolkit to use Services.jsm where possible (as found by the ESLint mozilla/use-services rule). I have a patch for changing about half the remaining instances in toolkit/ to use Services.jsm, which I think is a reasonable size to land now, and then we can land the rest later.
Comment on attachment 8929027 [details] Bug 1417940 - Change various instances of manually calling getService to use Services.jsm in toolkit/. https://reviewboard.mozilla.org/r/200346/#review205610
Attachment #8929027 - Flags: review?(dtownsend) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/2c2f807e23b5 Change various instances of manually calling getService to use Services.jsm in toolkit/. r=mossop
Backed out for failing browser chrome browser/components/contextualidentity/test/browser/browser_aboutURLs.js on a CLOSED TREE Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=145609111&repo=autoland&lineNumber=4621 Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2c2f807e23b5e43928f435f7e7c368b4c2b7d38e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=success&filter-searchStr=3560868809d652746f7bc4676c959db2c02714d0&selectedJob=145609111 Backout: https://hg.mozilla.org/integration/autoland/rev/10df6e7390f6e380de796950a77cbcdd91a6342c
I've undone the change that caused the leak as I don't know the reason for it - I've filed bug 1418959 as a follow-up.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/3cffb9b8872b Change various instances of manually calling getService to use Services.jsm in toolkit/. r=mossop
You need to log in before you can comment on or make changes to this bug.