1417940 - Change various instances of manually calling getService to use Services.jsm in toolkit/

Status: RESOLVED FIXED

(Toolkit :: General, enhancement)

Description

[Mark Banner (:standard8)]

I'm working on transition all of toolkit to use Services.jsm where possible (as found by the ESLint mozilla/use-services rule).

I have a patch for changing about half the remaining instances in toolkit/ to use Services.jsm, which I think is a reasonable size to land now, and then we can land the rest later.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1417940 - Change various instances of manually calling getService to use Services.jsm in toolkit/.

Review commit: https://reviewboard.mozilla.org/r/200346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200346/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8929027 [details]
Bug 1417940 - Change various instances of manually calling getService to use Services.jsm in toolkit/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200346/diff/1-2/

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8929027 [details]
Bug 1417940 - Change various instances of manually calling getService to use Services.jsm in toolkit/.

https://reviewboard.mozilla.org/r/200346/#review205610

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c2f807e23b5
Change various instances of manually calling getService to use Services.jsm in toolkit/. r=mossop

Comment 5

[Andreea Pavel [:apavel]]

Backed out for failing browser chrome browser/components/contextualidentity/test/browser/browser_aboutURLs.js on a CLOSED TREE

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=145609111&repo=autoland&lineNumber=4621

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2c2f807e23b5e43928f435f7e7c368b4c2b7d38e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=success&filter-searchStr=3560868809d652746f7bc4676c959db2c02714d0&selectedJob=145609111

Backout: https://hg.mozilla.org/integration/autoland/rev/10df6e7390f6e380de796950a77cbcdd91a6342c

Comment 6

[Mark Banner (:standard8)]

I've undone the change that caused the leak as I don't know the reason for it - I've filed bug 1418959 as a follow-up.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8929027 [details]
Bug 1417940 - Change various instances of manually calling getService to use Services.jsm in toolkit/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200346/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cffb9b8872b
Change various instances of manually calling getService to use Services.jsm in toolkit/. r=mossop

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3cffb9b8872b