Closed
Bug 1417944
Opened 7 years ago
Closed 7 years ago
Enable ESLint rule mozilla/use-services for toolkit/
Categories
(Toolkit :: General, enhancement)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(2 files)
As we've been doing elsewhere, we should turn on mozilla/use-services for toolkit and avoid the overhead of going via .getService.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 3•7 years ago
|
||
Try is showing an issue with my xpinstallConfirm.js changes. I think I've got a fix for it, but I really can't work out how to get that dialog up. I've tried a few things, including finding old non-webextensions, and removing amo from the whitelist etc. The code that I need to trigger is here: https://searchfox.org/mozilla-central/rev/797c93d81fe446f78babf20894f0729f15f71ee6/toolkit/mozapps/extensions/AddonManager.jsm#2880 Anyone any ideas?
Flags: needinfo?(rhelmer)
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8930886 [details] Bug 1417944 - Enable ESLint rule mozilla/use-services for toolkit/. https://reviewboard.mozilla.org/r/202002/#review207520
Attachment #8930886 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 5•7 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #3) > Try is showing an issue with my xpinstallConfirm.js changes. I think I've > got a fix for it, but I really can't work out how to get that dialog up. > I've tried a few things, including finding old non-webextensions, and > removing amo from the whitelist etc. > > The code that I need to trigger is here: > > https://searchfox.org/mozilla-central/rev/ > 797c93d81fe446f78babf20894f0729f15f71ee6/toolkit/mozapps/extensions/ > AddonManager.jsm#2880 > > Anyone any ideas? Have you tried setting xpinstall.customConfirmationUI to false? This should (assuming it still works!) trigger the old install UI.
|
|
Assignee | |
Comment 6•7 years ago
|
||
I finally found a way to test the dialog - I manually invoked it via Services.ww.openWindow in the browser console. So I'm happy my fix works now, though it may be worth investigating if that UI is really still accessible somehow.
Flags: needinfo?(rhelmer)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 9•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8930885 [details] Bug 1417944 - Enable ESLint rule mozilla/use-services for toolkit/mozapps/extensions. https://reviewboard.mozilla.org/r/202000/#review208288 ::: toolkit/mozapps/extensions/nsBlocklistService.js:83 (Diff revision 2) > -XPCOMUtils.defineLazyGetter(this, "gPref", function() { > - return Cc["@mozilla.org/preferences-service;1"].getService(Ci.nsIPrefService). > - QueryInterface(Ci.nsIPrefBranch); > -}); > +// XPCOMUtils.defineLazyGetter(this, "Services.prefs", function() { > +// return Cc["@mozilla.org/preferences-service;1"].getService(Ci.nsIPrefService). > +// QueryInterface(Ci.nsIPrefBranch); > +// }); please just remove this
Attachment #8930885 -
Flags: review?(aswan) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 12•7 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3f946c460cd1 Enable ESLint rule mozilla/use-services for toolkit/mozapps/extensions. r=aswan https://hg.mozilla.org/integration/autoland/rev/f7e3a378ee3d Enable ESLint rule mozilla/use-services for toolkit/. r=mossop
|
||
Comment 13•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3f946c460cd1 https://hg.mozilla.org/mozilla-central/rev/f7e3a378ee3d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•