1418002 - Remove HTMLContentElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I'm working on this still today.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: parser bits

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Translation from java files to c++ is currently busted, so need to do some manual fixing.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: remove_content_element.diff

This is on top of hg rev 0feeb8b372b7

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/4eb0e35b599b0fcafc0c156c5013214970b322c5
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=4eb0e35b599b0fcafc0c156c5013214970b322c5
remote: recorded changegroup in replication log in 0.048s


ShadowRoot could be cleaned up some more.

Comment 5

[Henri Sivonen (:hsivonen)]

(In reply to Olli Pettay [:smaug] from comment #3)
> Translation from java files to c++ is currently busted, so need to do some
> manual fixing.

Was this just a matter of the htmlparser repo part of bug 1378079 being missing?

Comment 6

[Henri Sivonen (:hsivonen)]

Comment on attachment 8929318 [details] [diff] [review]
parser bits

r+ on the assumption that the patch came out of the translator and the manual fixing was ignoring the changes to AttributeNames.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Oh, the manual fixing was for the other patch. translator outputs still nsIAtoms, when Gecko has nsAtoms.

Comment 8

[Henri Sivonen (:hsivonen)]

(In reply to Olli Pettay [:smaug] from comment #7)
> Oh, the manual fixing was for the other patch. translator outputs still
> nsIAtoms, when Gecko has nsAtoms.

I see. Pre-emptive r+ for s/nsIAtom/nsAtom/ in https://hg.mozilla.org/projects/htmlparser/file/449e628fa195/translator-src/nu/validator/htmlparser/cpptranslate/CppTypes.java .

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: remove_content_element_2.diff

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/e4973a1b1174be71390bff4b750cf0d11997b0c0
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4973a1b1174be71390bff4b750cf0d11997b0c0

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Attachment: remove_content_element_3.diff

MatchedNodes part is a bit ugly, but hopefully only temporary.
If not, we can clean it up.

And there is still more to clean up.

I removed couple of very v0 specific tests and disabled some others.

remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9e6dda487b51a482fd5534daa0947e3f1e51259
remote: recorded changegroup in replication log in 0.053s

Comment 11

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8932766 [details] [diff] [review]
remove_content_element_3.diff

Review of attachment 8932766 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, as long as the try results are green.

Note: ShadowRoot::IsPooledNode(), DistributeAllNodes(), mInsertionPointChanged can be removed too. We can do it after Bug 1409975.

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=18cf8e1367495c03246d7c1d3ed1317fd9f31f8f

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=6537f8d7644d845ecd9a66fcdefe0837130a40c2
remote: recorded changegroup in replication log in 0.049s

Comment 14

[Olli Pettay [:smaug][[e-mail]]]

Attachment: remove_content_element_4.diff

rebase

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0edf2e2f0bfd
Remove HTMLContentElement, r=jessica

Comment 16

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/projects/htmlparser/rev/a02847df183f5e69003dbb700be4658c4191e51c

Comment 17

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0edf2e2f0bfd