Remove HTMLContentElement

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

(Blocks 1 bug)

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(4 attachments, 1 obsolete attachment)

.
I'm working on this still today.
Posted patch parser bitsSplinter Review
Attachment #8929318 - Flags: review?(hsivonen)
Translation from java files to c++ is currently busted, so need to do some manual fixing.
Depends on: 1378079
Posted patch remove_content_element.diff (obsolete) — Splinter Review
This is on top of hg rev 0feeb8b372b7

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/4eb0e35b599b0fcafc0c156c5013214970b322c5
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=4eb0e35b599b0fcafc0c156c5013214970b322c5
remote: recorded changegroup in replication log in 0.048s


ShadowRoot could be cleaned up some more.
(In reply to Olli Pettay [:smaug] from comment #3)
> Translation from java files to c++ is currently busted, so need to do some
> manual fixing.

Was this just a matter of the htmlparser repo part of bug 1378079 being missing?
Comment on attachment 8929318 [details] [diff] [review]
parser bits

r+ on the assumption that the patch came out of the translator and the manual fixing was ignoring the changes to AttributeNames.
Attachment #8929318 - Flags: review?(hsivonen) → review+
Oh, the manual fixing was for the other patch. translator outputs still nsIAtoms, when Gecko has nsAtoms.
(In reply to Olli Pettay [:smaug] from comment #7)
> Oh, the manual fixing was for the other patch. translator outputs still
> nsIAtoms, when Gecko has nsAtoms.

I see. Pre-emptive r+ for s/nsIAtom/nsAtom/ in https://hg.mozilla.org/projects/htmlparser/file/449e628fa195/translator-src/nu/validator/htmlparser/cpptranslate/CppTypes.java .
Priority: -- → P3
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/e4973a1b1174be71390bff4b750cf0d11997b0c0
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4973a1b1174be71390bff4b750cf0d11997b0c0
Attachment #8929338 - Attachment is obsolete: true
Blocks: 1421540
Blocks: 1421542
Blocks: 1421545
Blocks: 1421546
No longer blocks: 1421540
No longer blocks: 1421542
No longer blocks: 1421545
No longer blocks: 1421546
MatchedNodes part is a bit ugly, but hopefully only temporary.
If not, we can clean it up.

And there is still more to clean up.

I removed couple of very v0 specific tests and disabled some others.

remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9e6dda487b51a482fd5534daa0947e3f1e51259
remote: recorded changegroup in replication log in 0.053s
Attachment #8932766 - Flags: review?(jjong)
Comment on attachment 8932766 [details] [diff] [review]
remove_content_element_3.diff

Review of attachment 8932766 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, as long as the try results are green.

Note: ShadowRoot::IsPooledNode(), DistributeAllNodes(), mInsertionPointChanged can be removed too. We can do it after Bug 1409975.
Attachment #8932766 - Flags: review?(jjong) → review+
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=18cf8e1367495c03246d7c1d3ed1317fd9f31f8f
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=6537f8d7644d845ecd9a66fcdefe0837130a40c2
remote: recorded changegroup in replication log in 0.049s
rebase
https://hg.mozilla.org/mozilla-central/rev/0edf2e2f0bfd
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.