1418216 - move IsCSSSheetType out of nsStyleSet

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Cameron McCormack (:heycam)]

nsStyleSet will go away soon and we still have some callers to this function.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1418216 - Move IsCSSSheetType out of nsStyleSet.

Review commit: https://reviewboard.mozilla.org/r/200662/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200662/

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8929337 [details]
Bug 1418216 - Move IsCSSSheetType out of nsStyleSet.

https://reviewboard.mozilla.org/r/200662/#review205868

::: layout/style/SheetType.h:26
(Diff revision 1)
>  enum class SheetType : uint8_t {
>    Agent, // CSS
>    User, // CSS
>    PresHint,
>    Doc, // CSS
>    ScopedDoc,

Please add a comment "// CSS" after `ScopeDoc,` so that it's consistent with `IsCSSSheetType()` below.

::: layout/style/SheetType.h:36
(Diff revision 1)
> +/**
> + * Returns whether aSheetType represents a level of the cascade that uses
> + * a StyleSheet object.
> + */

Nit: Maybe using C++ style of comments for this so that it's consistent with other comments.

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8929337 [details]
Bug 1418216 - Move IsCSSSheetType out of nsStyleSet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200662/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e61859f4ce41
Move IsCSSSheetType out of nsStyleSet. r=TYLin

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e61859f4ce41