Closed Bug 1418216 Opened 3 years ago Closed 3 years ago

move IsCSSSheetType out of nsStyleSet

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

nsStyleSet will go away soon and we still have some callers to this function.
Comment on attachment 8929337 [details]
Bug 1418216 - Move IsCSSSheetType out of nsStyleSet.

https://reviewboard.mozilla.org/r/200662/#review205868

::: layout/style/SheetType.h:26
(Diff revision 1)
>  enum class SheetType : uint8_t {
>    Agent, // CSS
>    User, // CSS
>    PresHint,
>    Doc, // CSS
>    ScopedDoc,

Please add a comment "// CSS" after `ScopeDoc,` so that it's consistent with `IsCSSSheetType()` below.

::: layout/style/SheetType.h:36
(Diff revision 1)
> +/**
> + * Returns whether aSheetType represents a level of the cascade that uses
> + * a StyleSheet object.
> + */

Nit: Maybe using C++ style of comments for this so that it's consistent with other comments.
Attachment #8929337 - Flags: review?(tlin) → review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e61859f4ce41
Move IsCSSSheetType out of nsStyleSet. r=TYLin
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/e61859f4ce41
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Assignee: nobody → cam
You need to log in before you can comment on or make changes to this bug.