1418287 - Add preference to disable native notifications (and use XUL notifications instead)

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, enhancement)

Description

[Rob Wu [:robwu]]

Bug 858919 brought native desktop notification support through libnotify to Linux.
I did not like the UX back then and created and add-on to revert back to XUL notifications: https://addons.mozilla.org/en-US/firefox/addon/no-native-notifications/

With Firefox 57, this add-on does not work any more.
I tried to give native notifications another go, but was disappointed by the buggy behavior:

bug 1418281 (onclick is not fired at all, onclose is fired too early)
bug 1417846 (requireInteraction is not supported)

I want an option to revert back to XUL notifications, to be able to continue using desktop notifications until the above issues are resolved.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1418287 - Add preference to disable the system notification service

Review commit: https://reviewboard.mozilla.org/r/200740/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200740/

Comment 2

[Rob Wu [:robwu]]

I manually tested that the patch works, as follows:

1. Build Firefox with the patch.
2. Run:
Notification.requestPermission().then(() => new Notification('hello'));
3. Confirm that a system notification is shown (=current default behavior).
4. Visit about:config, search for the name of the pref (alerts.useSystemBackend) and flip it (to false).
5. Repeat step 2, and confirm that a XUL notification is shown.
6. Repeat step 4 to flip the pref back to true.
7. Repeat step 2, and confirm that a system notification is shown.

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8929414 [details]
Bug 1418287 - Add preference to disable the system notification service

https://reviewboard.mozilla.org/r/200740/#review205950

::: toolkit/components/alerts/nsAlertsService.cpp:177
(Diff revision 1)
> +bool nsAlertsService::ShouldUseSystemBackend()
> +{
> +  if (!mBackend) {
> +    return false;
> +  }
> +  return Preferences::GetBool("alerts.useSystemBackend", true);

AddBoolVarCache instead.

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8929414 [details]
Bug 1418287 - Add preference to disable the system notification service

https://reviewboard.mozilla.org/r/200740/#review205952

I want to see it again with AddBoolVarCache.

Comment 5

[Rob Wu [:robwu]]

Comment on attachment 8929414 [details]
Bug 1418287 - Add preference to disable the system notification service

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200740/diff/1-2/

Comment 6

[Andrea Marchesini [:baku]]

Comment on attachment 8929414 [details]
Bug 1418287 - Add preference to disable the system notification service

https://reviewboard.mozilla.org/r/200740/#review205980

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/490462a74289
Add preference to disable the system notification service r=baku

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/490462a74289