Closed
Bug 1418459
Opened 7 years ago
Closed 6 years ago
Confirm that the 'menuitem-iconic-desc-noaccel' binding is never used and remove it
Categories
(Core :: XUL, task, P5)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla60
People
(Reporter: bgrins, Assigned: timdream)
References
Details
(Whiteboard: [xbl-available])
Attachments
(1 file)
AFAICT this is never used in m-c and has maybe one usage in c-c: https://dxr.mozilla.org/mozilla-central/search?q=menuitem-iconic-desc-noaccel https://dxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/menu.xml#250 It's bound to `menuitem[description]` in xul.css. No hits for 'description=' in xul files on m-c and the only hits on c-c appear to be wizard-related: - https://dxr.mozilla.org/mozilla-central/search?q=path%3Axul+%22description%3D%22 - https://dxr.mozilla.org/comm-central/search?q=path%3Axul+%22description%3D%22 No relevant hits for "inherits description": - https://dxr.mozilla.org/mozilla-central/search?q=inherits+description - https://dxr.mozilla.org/comm-central/search?q=inherits+description One hit in a test for "menuitem description" in m-c: - https://dxr.mozilla.org/mozilla-central/search?q=menuitem+description&redirect=true And one hit in im/ for "menuitem description" in c-c: - https://dxr.mozilla.org/comm-central/search?q=menuitem+description - https://dxr.mozilla.org/comm-central/source/im/content/conversation.xml#2255
|
||
Updated•7 years ago
|
status-firefox57:
--- → wontfix
status-firefox58:
--- → wontfix
status-firefox59:
--- → fix-optional
Priority: -- → P5
|
Reporter | |
Updated•7 years ago
|
Whiteboard: [xbl-remove-unused] → [xbl-available]
|
|
Reporter | |
Comment 1•7 years ago
|
||
I'm pretty sure this isn't used.. I did a try push where I print every call to `nsXBLBinding::SetBoundElement` and it doesn't appear in the output: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aaccf2c1ff6b66b52bcfa1390b78bb781b86f672&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=148874008
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → timdream
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
Patch to remove: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba6fc93c56467648ff065483fabecd94fcbb6665
| Comment hidden (mozreview-request) |
|
||
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8948963 [details] Bug 1418459 - Remove menuitem-iconic-desc-noaccel binding. https://reviewboard.mozilla.org/r/218376/#review224230 Thanks!
Attachment #8948963 -
Flags: review?(paolo.mozmail) → review+
Pushed by timdream@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3e48e8afae60 Remove menuitem-iconic-desc-noaccel binding. r=Paolo
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3e48e8afae60
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Comment 7•6 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
|
||
Updated•6 years ago
|
|
||
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•