Confirm that the 'menuitem-iconic-desc-noaccel' binding is never used and remove it

RESOLVED FIXED in Firefox 60

Status

()

P5
normal
RESOLVED FIXED
a year ago
9 months ago

People

(Reporter: bgrins, Assigned: timdream)

Tracking

(Blocks: 1 bug)

unspecified
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix, firefox59 wontfix, firefox60 fixed)

Details

(Whiteboard: [xbl-available])

Attachments

(1 attachment)

Updated

a year ago
status-firefox57: --- → wontfix
status-firefox58: --- → wontfix
status-firefox59: --- → fix-optional
Priority: -- → P5
Whiteboard: [xbl-remove-unused] → [xbl-available]
I'm pretty sure this isn't used.. I did a try push where I print every call to `nsXBLBinding::SetBoundElement` and it doesn't appear in the output: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aaccf2c1ff6b66b52bcfa1390b78bb781b86f672&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=148874008
Assignee: nobody → timdream
Status: NEW → ASSIGNED

Comment 4

a year ago
mozreview-review
Comment on attachment 8948963 [details]
Bug 1418459 - Remove menuitem-iconic-desc-noaccel binding.

https://reviewboard.mozilla.org/r/218376/#review224230

Thanks!
Attachment #8948963 - Flags: review?(paolo.mozmail) → review+

Comment 5

a year ago
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3e48e8afae60
Remove menuitem-iconic-desc-noaccel binding. r=Paolo
https://hg.mozilla.org/mozilla-central/rev/3e48e8afae60
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60

Updated

a year ago
Depends on: 1437306
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
status-firefox59: fix-optional → wontfix
You need to log in before you can comment on or make changes to this bug.