Closed Bug 1418459 Opened 4 years ago Closed 4 years ago

Confirm that the 'menuitem-iconic-desc-noaccel' binding is never used and remove it

Categories

(Core :: XUL, task, P5)

task

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: bgrins, Assigned: timdream)

References

Details

(Whiteboard: [xbl-available])

Attachments

(1 file)

Priority: -- → P5
Whiteboard: [xbl-remove-unused] → [xbl-available]
I'm pretty sure this isn't used.. I did a try push where I print every call to `nsXBLBinding::SetBoundElement` and it doesn't appear in the output: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aaccf2c1ff6b66b52bcfa1390b78bb781b86f672&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=148874008
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Comment on attachment 8948963 [details]
Bug 1418459 - Remove menuitem-iconic-desc-noaccel binding.

https://reviewboard.mozilla.org/r/218376/#review224230

Thanks!
Attachment #8948963 - Flags: review?(paolo.mozmail) → review+
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3e48e8afae60
Remove menuitem-iconic-desc-noaccel binding. r=Paolo
https://hg.mozilla.org/mozilla-central/rev/3e48e8afae60
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Depends on: 1437306
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.