1418459 - Confirm that the 'menuitem-iconic-desc-noaccel' binding is never used and remove it

Status: RESOLVED FIXED

(Core :: XUL, task, P5)

Description

[Brian Grinstead [:bgrins]]

AFAICT this is never used in m-c and has maybe one usage in c-c:

https://dxr.mozilla.org/mozilla-central/search?q=menuitem-iconic-desc-noaccel
https://dxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/menu.xml#250

It's bound to `menuitem[description]` in xul.css.

No hits for 'description=' in xul files on m-c and the only hits on c-c appear to be wizard-related:
- https://dxr.mozilla.org/mozilla-central/search?q=path%3Axul+%22description%3D%22
- https://dxr.mozilla.org/comm-central/search?q=path%3Axul+%22description%3D%22

No relevant hits for "inherits description":
- https://dxr.mozilla.org/mozilla-central/search?q=inherits+description
- https://dxr.mozilla.org/comm-central/search?q=inherits+description

One hit in a test for "menuitem description" in m-c:
- https://dxr.mozilla.org/mozilla-central/search?q=menuitem+description&redirect=true

And one hit in im/ for "menuitem description" in c-c:
- https://dxr.mozilla.org/comm-central/search?q=menuitem+description
- https://dxr.mozilla.org/comm-central/source/im/content/conversation.xml#2255

Comment 1

[Brian Grinstead [:bgrins]]

I'm pretty sure this isn't used.. I did a try push where I print every call to `nsXBLBinding::SetBoundElement` and it doesn't appear in the output: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aaccf2c1ff6b66b52bcfa1390b78bb781b86f672&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=148874008

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Patch to remove: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba6fc93c56467648ff065483fabecd94fcbb6665

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1418459 - Remove menuitem-iconic-desc-noaccel binding.

Review commit: https://reviewboard.mozilla.org/r/218376/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218376/

Comment 4

[:Paolo Amadini]

Comment on attachment 8948963 [details]
Bug 1418459 - Remove menuitem-iconic-desc-noaccel binding.

https://reviewboard.mozilla.org/r/218376/#review224230

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e48e8afae60
Remove menuitem-iconic-desc-noaccel binding. r=Paolo

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3e48e8afae60

Comment 7

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336