1437306 - TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/message-header/test-reply-identity.js (due to removed menuitem-iconic-desc-noaccel)

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[:aceman]

SUMMARY-UNEXPECTED-FAIL | test-reply-identity.js | test-reply-identity.js::test_reply_no_matching_identity
 INFO -    EXCEPTION: identityList.selectedItem.label is undefined
 INFO -      at: test-reply-identity.js line 111
 INFO -         checkReply test-reply-identity.js:111 7
 INFO -         test_reply_no_matching_identity test-reply-identity.js:125 3

This is caused because the identity picker in compose window does not work, it does not open properly, showing no identities.

Comment 1

[:aceman]

Attachment: 1437306.patch

This is caused by missing chrome://global/content/bindings/menu.xml#menuitem-iconic-desc-noaccel binding, removed in bug 1418459.

The last user is in Linux theme. Can you see if we loose anything by just removing the reference?
The test passes with this change and identity picker works.

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 8950009 [details] [diff] [review]
1437306.patch

It's okay to remove here. I need to restore the removals from bug 1418459 in a new bug and add the binding globally.

Comment 3

[:aceman]

Thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/10d683309c4d
remove menu.xml#menuitem-iconic-desc-noaccel binding. r=Paenglab