1418511 - watchman requires VS 2013 redistributable

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Mike Hommey [:glandium]]

We run watchman --version of something akin to that during configure, and that pops up a "can't find msvcr120.dll" dialog.

Comment 1

[Gregory Szorc [:gps]]

Boo.

Microsoft allows us to redistribute msvcr120.dll. So we can throw a copy in the same directory as watchman.exe (or anywhere in PATH in MozillaBuild I think).

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I don't suppose we could talk upstream into statically linking the CRT to avoid this?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Also, I'm going to ship 3.1.1 with fsmonitor disabled again, so I'm taking this off the radar for that release. It should block whatever bug gets filed for re-enabling it by default, though.

Comment 4

[Gregory Szorc [:gps]]

Filed https://github.com/facebook/watchman/issues/552 upstream.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Confirmed on a fresh Win10 VM with no extra runtimes installed that watchman can run without issue, which concurs with the upstream report. Doesn't look like there's anything we need to do here at this point.