Closed
Bug 1418525
Opened 7 years ago
Closed 7 years ago
Port bug 1405670 to TB: remove support for NS_APP_SEARCH_DIR_LIST and NS_APP_SEARCH_DIR from the directory service
Categories
(Thunderbird :: General, enhancement)
Thunderbird
General
Tracking
(thunderbird58 fixed, thunderbird59 fixed)
RESOLVED
FIXED
Thunderbird 59.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
3.67 KB,
patch
|
aceman
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Bustage error: /builds/slave/tb-c-cen-m64-00000000000000000/build/mail/components/shell/DirectoryProvider.cpp:178:21: error: use of undeclared identifier 'NS_APP_SEARCH_DIR_LIST'
if (!strcmp(aKey, NS_APP_SEARCH_DIR_LIST)) {
We need to port bug 1405670.
Assignee | ||
Comment 1•7 years ago
|
||
This patch seems to work. Build not finished but far away from the breakage. I haven't patched SM because some parts are missing from the FX and TB files and my skills aren't existent to do this.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8929656 -
Flags: review?(acelists)
Comment 2•7 years ago
|
||
Comment on attachment 8929656 [details] [diff] [review]
NS_APP_SEARCH_DIR_LIST.patch
Looks OK to me.
SM looks different, unless I'm missing something, and we don't have review power there anyway, so we might need leave it to them:
https://dxr.mozilla.org/comm-central/rev/99accbe79a6d60ee02878aa2b99f1c45e250b108/suite/profile/nsSuiteDirectoryProvider.cpp#66
Comment on attachment 8929656 [details] [diff] [review]
NS_APP_SEARCH_DIR_LIST.patch
Review of attachment 8929656 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, the change mimicks the m-c change in the same file and fixes building the file for me.
Attachment #8929656 -
Flags: review?(acelists) → review+
Pushed by richard.marti@gmail.com:
https://hg.mozilla.org/comm-central/rev/306fff0f8a9d
Port bug 1405670 to TB: remove support for NS_APP_SEARCH_DIR_LIST and NS_APP_SEARCH_DIR from the directory service. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 59.0
Comment 5•7 years ago
|
||
The NS_APP_DISTRIBUTION_SEARCH_DIR_LIST code that remains in the mail/ file seems pointless for TB, but I guess for ease of maintenance it's easier to keep the file in sync with m-c.
FYI, the m-c patch that caused this is likely to get uplifted.
Comment 6•7 years ago
|
||
Hmm NS_APP_USER_SEARCH_DIR still exists. Ist this one dead? Very unfriendly to the user then but probably nothing we can fix.
Comment 7•7 years ago
|
||
(In reply to Frank-Rainer Grahl (:frg) from comment #6)
> Hmm NS_APP_USER_SEARCH_DIR still exists. Ist this one dead? Very unfriendly
> to the user then
I don't understand what you mean here.
Comment 8•7 years ago
|
||
> I don't understand what you mean here.
This got removed:
- AppendFileKey(NS_APP_USER_SEARCH_DIR, dirSvc, baseFiles);
It is also in SeaMonkeys directory provider but I am not sure if it still does anything. NS_APP_USER_SEARCH_DIR is still defined in mozilla/xpcom/io/nsAppDirectoryServiceDefs.h but I am seeing no references to it other than in suite.
Comment 9•7 years ago
|
||
(In reply to Frank-Rainer Grahl (:frg) from comment #8)
> > I don't understand what you mean here.
>
> This got removed:
> - AppendFileKey(NS_APP_USER_SEARCH_DIR, dirSvc, baseFiles);
>
> It is also in SeaMonkeys directory provider but I am not sure if it still
> does anything. NS_APP_USER_SEARCH_DIR is still defined in
> mozilla/xpcom/io/nsAppDirectoryServiceDefs.h but I am seeing no references
> to it other than in suite.
Ah, right, I should have removed that define too. Thanks for noticing it!
(and no, it doesn't do anything anymore)
Comment 10•7 years ago
|
||
Comment on attachment 8929656 [details] [diff] [review]
NS_APP_SEARCH_DIR_LIST.patch
Needs uplift since bug 1405670 got uplifted on 2017-11-23. Since then, C-B builds have been busted, but no one noticed.
Attachment #8929656 -
Flags: approval-comm-beta+
Comment 11•7 years ago
|
||
Beta (TB 58):
https://hg.mozilla.org/releases/comm-beta/rev/18f5dfef9cbdda9bddebc9a2cc108322bfe61de1
status-thunderbird58:
--- → fixed
status-thunderbird59:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•