Add MOZ_CAN_RUN_SCRIPT annotations to some callers of Element::GetPrimaryFrame

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

(Blocks 1 bug)

53 Branch
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(4 attachments, 1 obsolete attachment)

No description provided.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8929688 - Attachment is obsolete: true
Attachment #8929688 - Flags: review?(nika)
Comment on attachment 8929764 [details] [diff] [review]
part 3.  Add MOZ_CAN_RUN_SCRIPT annotations to nsGenericHTMLElement methods that can call GetPrimaryFrame

Review of attachment 8929764 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/StaticAnalysisFunctions.h
@@ +53,5 @@
>  
>  #else
>  
>  #define MOZ_CHECK_ASSERT_ASSIGNMENT(expr) (!!(expr))
> +#define MOZ_KnownLive(expr) (expr)

I think it might be nice to pull this out into a separate patch.
Attachment #8929764 - Flags: review?(nika) → review+
Attachment #8929689 - Flags: review?(nika) → review+
Attachment #8929687 - Flags: review?(nika) → review+
Attachment #8929686 - Flags: review?(nika) → review+
> I think it might be nice to pull this out into a separate patch.

Will do.
Priority: -- → P2
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7378e5b6c059
part 1.  Add MOZ_CAN_RUN_SCRIPT annotations to most Element methods that call GetPrimaryFrame.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/79f3d55aba27
part 2.  Add MOZ_CAN_RUN_SCRIPT annotations to HTMLImageElement methods that call GetPrimaryFrame.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/3892362e7a24
part 3.  Make MOZ_KnownLive compile even when not doing a static analysis build.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/3247630382cb
part 4.  Add MOZ_CAN_RUN_SCRIPT annotations to nsGenericHTMLElement methods that can call GetPrimaryFrame.  r=mystor
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.