1418558 - Add MOZ_CAN_RUN_SCRIPT annotations to some callers of Element::GetPrimaryFrame

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Add MOZ_CAN_RUN_SCRIPT annotations to most Element methods that call GetPrimaryFrame

MozReview-Commit-ID: LWI1p75EyxB

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Add MOZ_CAN_RUN_SCRIPT annotations to HTMLImageElement methods that call GetPrimaryFrame

MozReview-Commit-ID: GxcrOxjTYDm

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Add MOZ_CAN_RUN_SCRIPT annotations to nsGenericHTMLElement methods that can call GetPrimaryFrame

MozReview-Commit-ID: HxFFC85qgOD

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Add MOZ_CAN_RUN_SCRIPT annotations to SVG methods that can call GetPrimaryFrame

MozReview-Commit-ID: KoXEBUa2OjR

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Add MOZ_CAN_RUN_SCRIPT annotations to nsGenericHTMLElement methods that can call GetPrimaryFrame

MozReview-Commit-ID: HxFFC85qgOD

Comment 6

[Nika Layzell [:nika] (ooo, ni? for response)]

Comment on attachment 8929764 [details] [diff] [review]
part 3.  Add MOZ_CAN_RUN_SCRIPT annotations to nsGenericHTMLElement methods that can call GetPrimaryFrame

Review of attachment 8929764 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/StaticAnalysisFunctions.h
@@ +53,5 @@
>  
>  #else
>  
>  #define MOZ_CHECK_ASSERT_ASSIGNMENT(expr) (!!(expr))
> +#define MOZ_KnownLive(expr) (expr)

I think it might be nice to pull this out into a separate patch.

Comment 7

[Boris Zbarsky [:bzbarsky]]

> I think it might be nice to pull this out into a separate patch.

Will do.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7378e5b6c059
part 1.  Add MOZ_CAN_RUN_SCRIPT annotations to most Element methods that call GetPrimaryFrame.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/79f3d55aba27
part 2.  Add MOZ_CAN_RUN_SCRIPT annotations to HTMLImageElement methods that call GetPrimaryFrame.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/3892362e7a24
part 3.  Make MOZ_KnownLive compile even when not doing a static analysis build.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/3247630382cb
part 4.  Add MOZ_CAN_RUN_SCRIPT annotations to nsGenericHTMLElement methods that can call GetPrimaryFrame.  r=mystor

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7378e5b6c059
https://hg.mozilla.org/mozilla-central/rev/79f3d55aba27
https://hg.mozilla.org/mozilla-central/rev/3892362e7a24
https://hg.mozilla.org/mozilla-central/rev/3247630382cb