1415230 - Add MOZ_CAN_RUN_SCRIPT annotations to things that can

Status: NEW

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

The idea is that things annotated MOZ_CAN_RUN_SCRIPT must have the caller holding on-stack strong refs to all refcounted arguments, including "this".  We added a static analysis for this in bug 1380423, but now we should actually use this annotation.

This is a tracking bug for this work.  I'll file some dependencies in a few minutes.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Add an opt-out for MOZ_CAN_RUN_SCRIPT's infectious nature

bz asked for something like this for testing on IRC, so I threw together a patch.

MozReview-Commit-ID: 2YKncUdrT5p

Comment 2

[Andrew McCreight [:mccr8]]

I've looked into something like this, based on adapting the GC rooting static analysis, but the way the GC rooting analysis is set up, you'd have to change the types of all of the raw pointer arguments to a type that explicitly roots, which seemed impractical.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Nika, do you mind landing that opt-out in a separate bug?  I think it will make it a _lot_ simpler to incrementally annotate things with MOZ_CAN_RUN_SCRIPT...

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Filed bug 1418465.