Open Bug 1415230 Opened 2 years ago Updated Last month
_CAN _RUN _SCRIPT annotations to things that can
The idea is that things annotated MOZ_CAN_RUN_SCRIPT must have the caller holding on-stack strong refs to all refcounted arguments, including "this". We added a static analysis for this in bug 1380423, but now we should actually use this annotation. This is a tracking bug for this work. I'll file some dependencies in a few minutes.
bz asked for something like this for testing on IRC, so I threw together a patch. MozReview-Commit-ID: 2YKncUdrT5p
I've looked into something like this, based on adapting the GC rooting static analysis, but the way the GC rooting analysis is set up, you'd have to change the types of all of the raw pointer arguments to a type that explicitly roots, which seemed impractical.
Nika, do you mind landing that opt-out in a separate bug? I think it will make it a _lot_ simpler to incrementally annotate things with MOZ_CAN_RUN_SCRIPT...
Filed bug 1418465.
Attachment #8926010 - Attachment is obsolete: true
Depends on: 1490222
Depends on: 1505029
Depends on: 1506439
Depends on: 1506441
Component: DOM → DOM: Core & HTML
Depends on: 1536401
Depends on: 1536736
Depends on: 1536737
Depends on: 1536738
Depends on: 1539013
Depends on: 1539016
You need to log in before you can comment on or make changes to this bug.