Turn on linux64 builds and test in taskcluster.

RESOLVED FIXED

Status

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tomprince, Assigned: tomprince)

Tracking

(Blocks 1 bug)

Trunk
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

Assignee

Description

2 years ago
No description provided.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Priority: -- → P1
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Attachment #8929700 - Flags: review?(philipp)
Attachment #8929701 - Flags: review?(philipp)
Attachment #8929702 - Flags: review?(philipp)
Attachment #8929703 - Flags: review?(philipp)

Comment 9

2 years ago
mozreview-review
Comment on attachment 8929700 [details]
Bug 1418593: Refactor linux64 mozconfigs to handle m-c topdir.

https://reviewboard.mozilla.org/r/200986/#review206488

::: mail/config/mozconfigs/common:6
(Diff revision 2)
> +if [ "$MOZ_IS_COMM_TOPDIR" == "1" ]; then
> +  ac_add_options --enable-application=mail
> +else
> +  ac_add_options --enable-application=comm/mail
> +fi
> +ac_add_options --enable-calendar

I think you recently defaulted --enable-calendar to true in that moz.configure patch. Maybe this is no longer needed then?
Attachment #8929700 - Flags: review?(philipp) → review+

Comment 10

2 years ago
mozreview-review
Comment on attachment 8929701 [details]
Bug 1418593: Enable linux64 builds in taskcluster.

https://reviewboard.mozilla.org/r/200988/#review206490

I don't really know a lot about TC, but reading the files it looks sane to me.
Attachment #8929701 - Flags: review?(philipp) → review+

Comment 11

2 years ago
mozreview-review
Comment on attachment 8929702 [details]
Bug 1418593: Enable xpcshell tests in taskcluster.

https://reviewboard.mozilla.org/r/200990/#review206492
Attachment #8929702 - Flags: review?(philipp) → review+

Comment 12

2 years ago
mozreview-review
Comment on attachment 8929703 [details]
Bug 1418593: Enable mozmill tests in taskcluster.

https://reviewboard.mozilla.org/r/200992/#review206494
Attachment #8929703 - Flags: review?(philipp) → review+
Assignee

Comment 13

2 years ago
mozreview-review-reply
Comment on attachment 8929700 [details]
Bug 1418593: Refactor linux64 mozconfigs to handle m-c topdir.

https://reviewboard.mozilla.org/r/200986/#review206488

> I think you recently defaulted --enable-calendar to true in that moz.configure patch. Maybe this is no longer needed then?

SeaMonkey had changed the default, and I preserved that in the moz.configure patch (which hasn't yet landed). I'd be happy to make that change for Thunderbird too in a seperate bug. I'm not sure who builds Thunderbird locally, and what behavior they expect.
Ah ok. Fine to keep it as is then, we can consider this at a later time.

Comment 15

2 years ago
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/comm-central/rev/5bfdd8678f3e
Refactor linux64 mozconfigs to handle m-c topdir; r=Fallen
https://hg.mozilla.org/comm-central/rev/8a7e6dbec102
Enable linux64 builds in taskcluster; r=Fallen
https://hg.mozilla.org/comm-central/rev/c61cae26239b
Enable xpcshell tests in taskcluster; r=Fallen
https://hg.mozilla.org/comm-central/rev/913f3f064116
Enable mozmill tests in taskcluster; r=Fallen
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.