1418701 - Fullscreen mode still not taking effect with Firefox 57

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Richard Maher]

User Agent: Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce:

Load my Brotkrumen Web App https://hypocampus.applications.uwa.edu.au/travelmanager.html and save to homescreen.

This is the manifest: -

{
  "short_name": "Brotkrumen",
  "name": "Brotkrumen Web App",
  "description": "Native Background Geolocation POC",
  "icons": [
    {
      "src": "gingerbreadhouse.png",
      "sizes": "48x48 128x128 144x144",
      "type": "image/png"
    }
  ],
  "start_url": "TravelManager.html",
  "background_color": "#00ccdd",
  "theme_color": "#00ccdd",
  "display": "fullscreen"
}


Actual results:

The display : fullscreen is not honoured.


Expected results:

The App should render in fullscreen mode without the browser chrome.

Comment 1

[Dylan Roeh (:droeh) (he/him)]

PWA support is not rolling out to release until 58, so I don't think we expect this to work in 57. I just tested quickly on Nightly and the fullscreen support there works as expected. Can you reproduce this issue in Beta or Nightly?

Comment 2

[Richard Maher]

I'll take your word for it Dylan but I have been eagerly awaiting this feature since it was heralded as coming in 57.

See https://developer.mozilla.org/en-US/Firefox/Releases/57

"The fullscreen value of the Web App Manifest display field is now supported in Firefox for Android 57 (bug 1126479)."

Anyway I reproduce on Beta 57.0b15 still doesn't work :-(

Feel free to try my App on any version you like.

Another *REALLY* annoying thing is every time I invoke my Web App from the homescreen I get a new Tab. This is horrendous and unworkable :-(

When B2G was alive you people were miles ahead of the pack on Web Apps. What's gone wrong? Do you have no intention of growing your Android presence?

Comment 3

[Dietrich Ayala (:dietrich)]

(In reply to Richard Maher from comment #2)
> I'll take your word for it Dylan but I have been eagerly awaiting this
> feature since it was heralded as coming in 57.
> 
> See https://developer.mozilla.org/en-US/Firefox/Releases/57
> 
> "The fullscreen value of the Web App Manifest display field is now supported
> in Firefox for Android 57 (bug 1126479)."
> 
> Anyway I reproduce on Beta 57.0b15 still doesn't work :-(
> 
> Feel free to try my App on any version you like.

You are totally correct.

If we're not supporting fullscreen mode in 57, it should not have been announced in the release notes.

We have a whole system for experimentally launching features (nightly and beta/devedition), so shipping something on the release channel that isn't ready is not something we should be doing.

I'll request information from the person who did the fullscreen work, to see what's going on in this case.

> Another *REALLY* annoying thing is every time I invoke my Web App from the
> homescreen I get a new Tab. This is horrendous and unworkable :-(
> 
> When B2G was alive you people were miles ahead of the pack on Web Apps.
> What's gone wrong? Do you have no intention of growing your Android presence?

Richard, I really appreciate that you filed the bug! However, please keep your comments to the problem at hand.

Making comments like this doesn't help the people working on the software solve the problem any faster, and just makes it more frustrating to do so.

Comment 4

[Dietrich Ayala (:dietrich)]

Snorp, looks like you landed fullscreen in bug 1126479 (oddly, that bug has code landed, but no assignee!).

Any ideas on what's going on here?

Comment 5

[Richard Maher]

Ok I'll spare the commentary.

NB: The new tab per web app invocation *is* a big deal! It can be controlled by Settings->Relaunch tabs on start but (eventually) without browser Chrome how withh someone know they've got 100 tabs open and just created a new one.

FYI The Web App quoted works with Chrome, Opera, and Android (requires status line) browser

Comment 6

[Dylan Roeh (:droeh) (he/him)]

(In reply to Richard Maher from comment #5)
> NB: The new tab per web app invocation *is* a big deal! It can be controlled
> by Settings->Relaunch tabs on start but (eventually) without browser Chrome
> how withh someone know they've got 100 tabs open and just created a new one.

This is being addressed in bug 1417650.

(In reply to Richard Maher from comment #2)
> Anyway I reproduce on Beta 57.0b15 still doesn't work :-(

Sorry, I should've been clearer in my post -- PWAs should be enabled in 58 (and 59), which should be beta (and nightly). But we do some sort of phased rollout on the Play store and it looks like Beta hasn't updated to 58 for everyone yet. If you're particularly eager to check, you can download the Beta apk directly here: https://ftp.mozilla.org/pub/mobile/releases/58.0b3/ (you most likely want the android-api-16 release if you're unsure of which to download). I checked with this version just now and can confirm your PWA installs correctly and launches in fullscreen mode.

Sorry for the confusion!

Comment 7

[Richard Maher]

Thanks Dylan. All is good in the version you gave me!

Really like being asked to add to homescreen!

Well done all. Keep it up!

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Dietrich Ayala (:dietrich) from comment #4)
> Snorp, looks like you landed fullscreen in bug 1126479 (oddly, that bug has
> code landed, but no assignee!).
> 
> Any ideas on what's going on here?

This works only in Fennec 58+

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #8)
> (In reply to Dietrich Ayala (:dietrich) from comment #4)
> > Snorp, looks like you landed fullscreen in bug 1126479 (oddly, that bug has
> > code landed, but no assignee!).
> > 
> > Any ideas on what's going on here?
> 
> This works only in Fennec 58+

Oh I see the problem -- that particular bug landed in 57, but PWA are not enabled at all until 58. Hope this clears things up.

Comment 10

[Dietrich Ayala (:dietrich)]

Ok, thanks Snorp! We definitely should remove from the release notes for 57 then.

Andreas, can you take a look at how we can remove this from the release notes?

I would say to amend it, but since it does not actually work at all, we shouldn't be encouraging anyone to try and use it in 57.

Comment 11

[Andreas Bovens [:abovens]]

Yup, I'll follow up. Strange this slipped through.