1418830 - One should not enable gfx.webrender.hit-test. Crash in mozalloc_abort | abort | webrender::clip_scroll_tree::ClipScrollTree::is_point_clipped_in_for_node

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

I am sorry! I saw gfx.webrender.hit-test here[1] and wanted to find out what it does. It produced new crash signatures that are not associated to any bug.
[1] https://hg.mozilla.org/mozilla-central/file/bdab19ff2fef/gfx/thebes/gfxPrefs.h#l494

Invalid/Wontfix?

Meldungs-ID 	Sendedatum
bp-7e273df6-0256-45fd-b162-76d940171119 19.11.17 21:36 [@ mozalloc_abort | abort | webrender::clip_scroll_tree::ClipScrollTree::is_point_clipped_in_for_node ]
bp-1a6bdd95-9b31-4827-a714-1ecea0171119 19.11.17 21:36 [@ mozalloc_abort | abort | webrender::clip_scroll_tree::ClipScrollTree::is_point_clipped_in_for_node ]
bp-065f349a-d24d-410d-8018-a08880171119 19.11.17 21:36 [@ mozalloc_abort | abort | webrender::clip_scroll_tree::ClipScrollTree::is_point_clipped_in_for_node ]
bp-b6ecec38-3c97-430e-8308-d24c70171119 19.11.17 21:36 [@ mozalloc_abort | abort | webrender::clip_scroll_tree::ClipScrollTree::is_point_clipped_in_for_node ]

bp-26fc1116-e05a-483d-bef6-0914e0171119 19.11.17 21:36 [@ mozalloc_abort | abort | webrender::clip_scroll_tree::ClipScrollTree::is_point_clipped_in_for_node ]
> MOZ_CRASH Reason 	internal error: entered unreachable code: Tried to call contains on an unsupported ClipSource.
> GraphicsCriticalError Receive IPC close with reason=AbnormalShutdown (t=2132.65) |[31]CP+[GFX1-]: Failed to create WebRenderBridgeChild. (t=2133.58)

bp-ac39e875-184b-41b4-b406-f83a40171119 19.11.17 21:36 [@ nsObserverService::RemoveObserver ]
> MOZ_CRASH Reason 	MOZ_CRASH(Using observer service off the main thread!)
> GraphicsCriticalError Receive IPC close with reason=AbnormalShutdown (t=2131.81) |[C1][GFX1-]: Failed to create WebRenderBridgeChild. (t=2132.43)

bp-b28d25ac-a570-4151-b000-891820171119 19.11.17 21:36 [@ mozalloc_abort | abort | webrender::clip_scroll_tree::ClipScrollTree::is_point_clipped_in_for_node ]
bp-91ef0379-67ae-484b-836c-cb83f0171119 19.11.17 21:36 [@ mozalloc_abort | abort | webrender::clip_scroll_tree::ClipScrollTree::is_point_clipped_in_for_node ]

bp-20a26ebc-1701-4ed7-9378-843630171119 19.11.17 21:36 [@ nsObserverService::RemoveObserver ]
> MOZ_CRASH Reason 	MOZ_CRASH(Using observer service off the main thread!)

bp-5ae8393a-ff76-423b-a0f2-a0f750171119 19.11.17 21:36 [@ @0x4089d7 ]


(I saw that RemoveObserver signature already in my History Sidebar crash: bug 1418201)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Yeah, don't enable that.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Although I guess it really shouldn't be crashing like this either, so possibly a legitimate bug.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

This should be fixed in the WR update in bug 1420163.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Should be fixed now. Turning on gfx.webrender.hit-test right now should have no functional effect, but shouldn't crash either. After bug 1389146 lands, it will have a functional effect (which is known to be buggy) but it still shouldn't crash.