1418852 - Task 'max-run-time' specification is not being used for linux64-jsdcov

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Description

[Greg Mierzwinski [:sparky]]

In the push given here [1], we can see that the task is being timed out after 1 hour but we have specified a 2 hour max run time here [2].

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=372e721a3091ee4b87a385bd92286ba2dd023645&selectedJob=145963586
[2]: https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/test/mochitest.yml#106

Comment 1

[Greg Mierzwinski [:sparky]]

The task graph also contains the value 3600: https://public-artifacts.taskcluster.net/bazx0AL-RZG-el4CfmZB4A/0/public/task-graph.json

:dustin, would you have any ideas about how we could fix this?

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

by-* uses regular expressions, so `linux64-*cov/opt` would match `linux64cov/opt` and `linux64-------cov/opt` but not the platform you want it to :)

Comment 3

[Greg Mierzwinski [:sparky]]

Thanks for the quick reply Dustin! :)

I'll have a patch up to change this soon.

Comment 4

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1418852 - Fix 'max-run-time' specification for coverage builds.

This patch fixes the 'max-run-time' specification by adding the '.' before the '*' in 'linux64-.*cov'.

Review commit: https://reviewboard.mozilla.org/r/201426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201426/

Comment 5

[Greg Mierzwinski [:sparky]]

Comment on attachment 8930289 [details]
Bug 1418852 - Fix 'max-run-time' specification for coverage builds.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201426/diff/1-2/

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8930289 [details]
Bug 1418852 - Fix 'max-run-time' specification for coverage builds.

https://reviewboard.mozilla.org/r/201426/#review206948

Comment 7

[Greg Mierzwinski [:sparky]]

Thanks for the quick review Dustin!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/328ee69ec1bc
Fix 'max-run-time' specification for coverage builds. r=dustin

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/328ee69ec1bc