Closed Bug 1418852 Opened 2 years ago Closed 2 years ago

Task 'max-run-time' specification is not being used for linux64-jsdcov

Categories

(Testing :: Code Coverage, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: sparky, Assigned: sparky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In the push given here [1], we can see that the task is being timed out after 1 hour but we have specified a 2 hour max run time here [2].

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=372e721a3091ee4b87a385bd92286ba2dd023645&selectedJob=145963586
[2]: https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/test/mochitest.yml#106
The task graph also contains the value 3600: https://public-artifacts.taskcluster.net/bazx0AL-RZG-el4CfmZB4A/0/public/task-graph.json

:dustin, would you have any ideas about how we could fix this?
Flags: needinfo?(dustin)
by-* uses regular expressions, so `linux64-*cov/opt` would match `linux64cov/opt` and `linux64-------cov/opt` but not the platform you want it to :)
Flags: needinfo?(dustin)
Thanks for the quick reply Dustin! :)

I'll have a patch up to change this soon.
Comment on attachment 8930289 [details]
Bug 1418852 - Fix 'max-run-time' specification for coverage builds.

https://reviewboard.mozilla.org/r/201426/#review206948
Attachment #8930289 - Flags: review?(dustin) → review+
Thanks for the quick review Dustin!
Keywords: checkin-needed
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/328ee69ec1bc
Fix 'max-run-time' specification for coverage builds. r=dustin
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/328ee69ec1bc
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Assignee: nobody → gmierz2
You need to log in before you can comment on or make changes to this bug.