1419149 - Image from eml file not shown in SeaMonkey Composer

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Composition, defect)

Description

[Frank-Rainer Grahl (:frg)]

+++ This bug was initially created as a clone of Bug #1412639 +++

Description from bug 1412639:

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.102 Safari/537.36 Vivaldi/1.93.955.42

Steps to reproduce:

- create new user profile and set up mail account
- open run attached eml file
--> file opens in a separate mail window
- press Ctrl+E



Actual results:

- mail opens in composer
- image is not shown
- in the status bar, I see "thunderbird has blocked a file from loading into this message"
- clicking on "Preferences" I see "Unblock mailbox:///media/username/..."
--> Unless stated <a href="https://www.mozilla.org/en-US/thunderbird/52.0/releasenotes/">here</a>, this does'nt look like a data URI. It is the beginning of the local address of the eml file. 

Related: https://bugzilla.mozilla.org/show_bug.cgi?id=1366349 with  http://somup.com/cb1ZqzViwY


Expected results:

The image should be shown in composer and sent with the message.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1419149-imagefromeml.patch

The patch is an 1:1 port. But our "edit as new" is not working if I open a saved eml message. Looks like this needs to be fixed in another bug.

[Approval Request Comment]
Regression caused by (bug #): Bug 1322172
User impact if declined: right now no impact because prerequisite functionality is broken.
Testing completed (on m-c, etc.): c-r on 2.53 (56)
Risk to taking this patch (and alternatives if risky): straight port no risk.
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

The bug for edit as new is already filed as bug 1332705.

Comment 3

[Ian Neal]

Comment on attachment 8930209 [details] [diff] [review]
1419149-imagefromeml.patch

Assuming the helper eventually gets wider use...
r/a=me

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fcf78ba5b821
Image from eml file not shown in SeaMonkey Composer. r=IanN

Comment 5

[Frank-Rainer Grahl (:frg)]

> Assuming the helper eventually gets wider use...

Not sure but I think the code shouldn't be different from TB here. Might be candidate for a shared mailnews helper. Task #9998 :)

https://hg.mozilla.org/releases/comm-beta/rev/ca256043000660437bc96b9839e89feb2a56b124
https://hg.mozilla.org/releases/comm-esr52/rev/fe31da68fa51cce998d74d9aa204d2bbb388300f

Comment 6

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/8ac4a8228e233be55f048d19235500a798052afa