1332705 - 'Edit Message as new' does not work for message from file.eml

Status: NEW

(SeaMonkey :: MailNews: General, defect)

Description

[Rainer Bielefeld]

This one is a spin off from "Bug 241213 - Message window for .EML file needs working commands" - see h)!

Steps how to reproduce with Server-Installation of  official  en-US SeaMonkey 2.50a1 (NT 6.1; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0 Build 20170110004313  (Default Classic Theme) on German WIN7 64bit:

0. Download  Attachment 8826695 [details] Details for Bug 1331042
1. Launch Email Client
2. Menu 'File → Open File → Browse for "ThisIsAtestEmailFor_emlImport.eml"
   and open
   » File opens in new separate window
3. Menu 'Message → Edit Message as new ...'
   Expected: Email opens in new composer window
   Actual: nothing

a) This is not a general "Separate View Window" problem. I opened the 
   source email for the attachment form Drafts Email Folder with
   'Rightlick (in Thread Pane) → Open Message in New Window' and 
   tested Menu 'Message → Edit Message as new ...':
   works fine
b) reason for malfunction might be that the message in step 2 is not
   assigned to an email account
c) With TB 'Edit Message as new ...' works, but does it wrong. Sends 
   email from first (main) email account, what is correct.
   But uses sender address from .eml 
d) Suggested Solution: In step 3 always replace sender from .eml by 
   sender email address of main account
e) Possible relations to Bug 366482, Bug 392585

Comment 1

[Frank-Rainer Grahl (:frg)]

confirmed also for 2.49.1

I am seeing no error message in the log.

Comment 2

[Frank-Rainer Grahl (:frg)]

I suspect this was broken way earlier.

GetSelectedMsgFolders() returns null when the file is opened from the mail pane. 
ComposeMessage then just reutuns in the default switch for the type.

If an existing message is selected everything works. 

TB has its own GetSelectedMsgFolders() in mail\base\content\msgMail3PaneWindow.js which seems to work. But the code in way different from SeaMonkeys and can't be used 1:1. So either refactoring or a different solution is needed for SeaMonkey.

Comment 3

[Frank-Rainer Grahl (:frg)]

Sorry mixed it up. It is actually the GetSelectedMsgFolders() in suite/mailnews/messageWindow.js which is different.