1419259 - Fix compile build for Win* post landing of bug 1415811

Status: ASSIGNED

(SeaMonkey :: Build Config, enhancement)

Description

[Edmund Wong (:ewong)]

post-bug-1415811, we now use TOOLTOOL_DIR.  Unfortunately,
this is overwritten in win32 just before the compile step.

need to get win* to also use the TOOLTOOL_DIR env.

Comment 1

[Edmund Wong (:ewong)]

Attachment: [custom] proposed patch

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8930340 [details] [diff] [review]
[custom] proposed patch

r+ with a one liner comment please :)

Comment 3

[Frank-Rainer Grahl (:frg)]

> r+ with a one liner comment please :)

Oh was ambiguous. Additional comment in the file why neccessary for win.

Comment 4

[Edmund Wong (:ewong)]

(In reply to Frank-Rainer Grahl (:frg) from comment #3)
> > r+ with a one liner comment please :)
> 
> Oh was ambiguous. Additional comment in the file why neccessary for win.

Perhaps I should explain here instead since having a one line
comment to describe the removal of two lines really doesn't 
clarify much.

The win platform's build directory is overwritten with 'build' instead of
using the ('%(basedir)s/build') which will refer to e:/builds/slave/c-cen-win32-t/build
(or something like that).    right now, with the two lines, it will
refer the build dir as 'build/build' and this is not valid.

Comment 5

[Frank-Rainer Grahl (:frg)]

Thanks. Maybe just put a reference to the bug in the file for later?

Comment 6

[Shannon Owens]

Attachment: same problem

Thanks from tabtukindbert1989.