Closed Bug 1419546 Opened 2 years ago Closed 2 years ago

Crash in RetainedDisplayListBuilder::MergeDisplayLists

Categories

(Core :: Web Painting, defect, P1, critical)

Unspecified
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- disabled
firefox59 --- fixed

People

(Reporter: marcia, Assigned: mtseng)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is
report bp-b3cb89aa-ba20-40f6-86f9-8d0c20171118.
=============================================================

Seen while looking at nightly crash data: http://bit.ly/2zWeknf

Top 10 frames of crashing thread:

0 xul.dll RetainedDisplayListBuilder::MergeDisplayLists layout/painting/RetainedDisplayListBuilder.cpp:415
1 xul.dll RetainedDisplayListBuilder::MergeDisplayLists layout/painting/RetainedDisplayListBuilder.cpp:468
2 xul.dll RetainedDisplayListBuilder::AttemptPartialUpdate layout/painting/RetainedDisplayListBuilder.cpp:853
3 xul.dll nsLayoutUtils::PaintFrame layout/base/nsLayoutUtils.cpp:3827
4 xul.dll mozilla::PresShell::Paint layout/base/PresShell.cpp:6506
5 xul.dll nsViewManager::ProcessPendingUpdatesPaint view/nsViewManager.cpp:480
6 xul.dll nsViewManager::ProcessPendingUpdatesForView view/nsViewManager.cpp:412
7 xul.dll nsViewManager::ProcessPendingUpdates view/nsViewManager.cpp:1102
8 xul.dll nsRefreshDriver::Tick layout/base/nsRefreshDriver.cpp:2027
9 xul.dll mozilla::RefreshDriverTimer::TickDriver layout/base/nsRefreshDriver.cpp:336

=============================================================
Assignee: nobody → matt.woodrow
Blocks: 1352499
Priority: -- → P1
This is another duplicated table display item bug: https://pastebin.mozilla.org/9074242

Morris, would you be able to take a look at this one too please?
Flags: needinfo?(mtseng)
Adding 58 as affected.
Sure
Assignee: matt.woodrow → mtseng
Flags: needinfo?(mtseng)
Comment on attachment 8936625 [details]
Bug 1419546 - Consider mLayer in nsDisplayTableBackgroundImage::GetPerFrameKey().

https://reviewboard.mozilla.org/r/207366/#review213256
Attachment #8936625 - Flags: review?(matt.woodrow) → review+
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1444a77d7e45
Consider mLayer in nsDisplayTableBackgroundImage::GetPerFrameKey(). r=mattwoodrow
I submitted a try again and it looks like all green. https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c8b817dbe994947eeef4b0610256fedf84f9210

And I also re-triggered the fail build in https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1444a77d7e453402776fd08bfa72de2d40de46cf&group_state=expanded and it looks like green.

So I think the build bustage is not related to my patch. I'm going to reland it.
Flags: needinfo?(mtseng)
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97043a5a2d5e
Consider mLayer in nsDisplayTableBackgroundImage::GetPerFrameKey(). r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/97043a5a2d5e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
I'll call this disabled in 58.
You need to log in before you can comment on or make changes to this bug.