Closed
Bug 1419612
Opened 7 years ago
Closed 7 years ago
Convert Failure Summary panel to a React Component
Categories
(Tree Management :: Treeherder: Frontend, defect, P2)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sclements, Assigned: sclements)
References
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36
Expected results:
This is part of a project to replace all of the markup in each of the tab.content paths (/main.html) in the thTabs factory with react components.
Updated•7 years ago
|
Assignee: nobody → sclements313
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated•7 years ago
|
Blocks: treeherder-react
Updated•7 years ago
|
Priority: -- → P2
Comment 1•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8932694 -
Flags: review?(cdawson)
Comment 2•7 years ago
|
||
Comment on attachment 8932694 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/2999
Great job on this! Just a few things to clean up and you'll be good to go. :)
Attachment #8932694 -
Flags: review?(cdawson) → review-
Assignee | ||
Updated•7 years ago
|
Attachment #8932694 -
Flags: review- → review?(cdawson)
Comment 3•7 years ago
|
||
Looks like just one more small tweak that it needs and then we can merge it.
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Cameron Dawson [:camd] from comment #3)
> Looks like just one more small tweak that it needs and then we can merge it.
Just fixed it!
Comment 5•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/22e45576f6201469356145539e14ad578bdcb2c6
Bug 1419612 - convert failure summary panel to react components (#2999)
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Attachment #8932694 -
Flags: review?(cdawson) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•