Remove nsIGlobalHistory2.idl & docshell implementation of nsDownloadHistory

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
11 months ago

People

(Reporter: freesamael, Assigned: standard8)

Tracking

(Blocks 1 bug)

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

It seems we've deleted the only implementation - nsGlobalHistory - for many years. 
Event comm-central doesn't seem to have any implementation:
https://searchfox.org/comm-central/search?q=nsIGlobalHistory2&path=

We should remove the idl and clean up the dead code.
nsDownloadHistory.cpp that is the generic downloadhistory implementation (not used in firefox, but likely used in other software?) seems to use it yet.
Though, if there is no implementation of nsIGlobalHistory2, it's worthless to keep it around, so let's also remove nsDownloadHistory at this point. From a quick glance most callpoints are properly checking for success when instantiating an nsIDownloadHistory handler. Fwiw, the only consumer I am worried about is Android, but it should just do nothing, as before, since nsIGlobalHistory2 is not implemented.
Marco recently worked on excluding nsDownloadHistory from Firefox, maybe he could be interested into removing everything here, so cc-ing him.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Summary: Remove nsIGlobalHistory2.idl → Remove nsIGlobalHistory2.idl & docshell implementation of nsDownloadHistory
nsIGlobalHistory2 is not implemented by any mozilla-central nor comm-central applications, and hence can be removed. As a result, nsDownloadHistory's implementation can also be removed.

MozReview-Commit-ID: 5bQ2OHsV1Ky
Comment on attachment 8989524 [details]
Bug 1419704 - Remove nsIGlobalHistory2 and docshell's nsDownloadHistory as they are redundant.

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D1929
Attachment #8989524 - Flags: review+
Comment on attachment 8989524 [details]
Bug 1419704 - Remove nsIGlobalHistory2 and docshell's nsDownloadHistory as they are redundant.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D1929
Attachment #8989524 - Flags: review+

Comment 6

11 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2291d4737e17
Remove nsIGlobalHistory2 and docshell's nsDownloadHistory as they are redundant. r=mak,bzbarsky

Comment 7

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2291d4737e17
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.