1419820 - element is hiding half a page

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Eugene Savitsky]

Attachment: FF.png

http://www.htc.com/us/support/htc-u11/

It seems to be a Webrender issue.

Comment 1

[Eugene Savitsky]

Comment on attachment 8931020 [details]
FF.png

Scheenshot compare

Comment 2

[Darkspirit]

Confirmed in Nightly 59 x64 20171122103138 de_DE 5378dcb45044a160fad93b02eed0c617f3324dbc @ Debian Testing (KDE, Radeon RX480).
fresh profile: layers.acceleration.force-enabled, gfx.webrender.enabled

(layout.display-list.retain;false does not help.)
Fixed by disabling WebRender.

Comment 3

[Darkspirit]

http://www.htc.com/us/support/htc-u11/

mozregression --good 2017-10-02 --bad 2017-11-21 --pref "layers.acceleration.force-enabled:true" "gfx.webrender.enabled:true" "gfx.webrendest.enabled:true" "gfx.webrender.layers-free:true" "gfx.webrender.blob-images:true"
> [...]
> 6:17.12 INFO: Last good revision: 7192c463079726af269fcb0a41916a30a0276ace
> 6:17.12 INFO: First bad revision: 0dd64d5842e80da586e0c3bb3f9ed04e2b1b338e
> 6:17.12 INFO: Pushlog:
> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7192c463079726af269fcb0a41916a30a0276ace&tochange=0dd64d5842e80da586e0c3bb3f9ed04e2b1b338e
> 
> 6:18.81 INFO: ************* Switching to autoland
> [...]
> 8:47.67 INFO: No more inbound revisions, bisection finished.
> 8:47.67 INFO: Last good revision: 72d52134e37521561e0a00b0cfcb8027a41811b2
> 8:47.67 INFO: First bad revision: 74a760610fd045e505204fbef91c3a48c2c6133d
> 8:47.67 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=72d52134e37521561e0a00b0cfcb8027a41811b2&tochange=74a760610fd045e505204fbef91c3a48c2c6133d

> 74a760610fd0	Morris Tseng — Bug 1403459 - Passing transform-style from display item directly. r=kats

Comment 4

[Ethan Lin[:ethlin]]

It's a transform problem. I think we should fix it.

Comment 5

[Ethan Lin[:ethlin]]

Attachment: Bug 1419820 - For transform 3d, we should check if we have extended context as well.

Review commit: https://reviewboard.mozilla.org/r/202396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202396/

Comment 6

[Ethan Lin[:ethlin]]

There is a similar check[1] in nsDisplayTransform::BuildLayer.

[1] https://dxr.mozilla.org/mozilla-central/rev/4affa6e0a8c622e4c4152872ffc14b73103830ac/layout/painting/nsDisplayList.cpp#8481

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8931256 [details]
Bug 1419820 - For transform 3d, we should check if we have extended context as well.

https://reviewboard.mozilla.org/r/202396/#review207828

Can you add a reftest that captures this case? Obviously we don't have any existing reftests that capture this scenario and it would be good to have one.

Comment 8

[Ethan Lin[:ethlin]]

Attachment: Bug 1419820 - Add a reftest to test preserve-3d with transform.

Review commit: https://reviewboard.mozilla.org/r/202746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202746/

Comment 9

[Ethan Lin[:ethlin]]

Comment on attachment 8931256 [details]
Bug 1419820 - For transform 3d, we should check if we have extended context as well.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202396/diff/1-2/

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8931602 [details]
Bug 1419820 - Add a reftest to test preserve-3d with transform.

https://reviewboard.mozilla.org/r/202746/#review208126

Thanks!

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8931256 [details]
Bug 1419820 - For transform 3d, we should check if we have extended context as well.

https://reviewboard.mozilla.org/r/202396/#review208128

::: commit-message-b96f0:1
(Diff revision 2)
> +Bug 1419820 - For Transform 3d, we should check if the we have extended context as well. r=kats

s/the we/we/

Comment 12

[Ethan Lin[:ethlin]]

Comment on attachment 8931256 [details]
Bug 1419820 - For transform 3d, we should check if we have extended context as well.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202396/diff/2-3/

Comment 13

[Ethan Lin[:ethlin]]

Comment on attachment 8931602 [details]
Bug 1419820 - Add a reftest to test preserve-3d with transform.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202746/diff/1-2/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ade21c5e79ff
For transform 3d, we should check if we have extended context as well. r=kats
https://hg.mozilla.org/integration/autoland/rev/244d00781e19
Add a reftest to test preserve-3d with transform. r=kats

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ade21c5e79ff
https://hg.mozilla.org/mozilla-central/rev/244d00781e19

Comment 16

[Darkspirit]

http://www.htc.com/us/support/htc-u11/

mozregression --find-fix --bad 2017-11-21 --good 2017-11-28 --pref "layers.acceleration.force-enabled:true" "gfx.webrender.enabled:true" "gfx.webrender.blob-images:true"
> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f5f03ee9e6abf77964f8dc1b9d69c6ccd3f655fd&tochange=cff54d05bcad74654249e2a2d4735b491bc452fd

mozregression --repo autoland --launch <changeset> --pref "layers.acceleration.force-enabled:true" "gfx.webrender.enabled:true" "gfx.webrender.blob-images:true"
> good: ade21c5e79ff Ethan Lin — Bug 1419820 - For transform 3d, we should check if we have extended context as well. r=kats
> last bad: 70581f6aeb1d Makoto Kato — Bug 1416080 - Part 2. CreateMozBR should use native dom node. r=masayuki