Closed
Bug 1420030
Opened 6 years ago
Closed 6 years ago
[Fennec][HLS] Change HLS logging from BuildConfig.NIGHTLY_BUILD || BuildConfig.DEBUG_BUILD to !BuildConfig.MOZILLA_OFFICIAL
Categories
(Firefox for Android Graveyard :: Audio/Video, enhancement)
Firefox for Android Graveyard
Audio/Video
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: JamesCheng, Assigned: JamesCheng)
References
Details
Attachments
(1 file)
After turning on the HLS for all channels (Bug 1365505), we should make our debug flag change from DEBUG = BuildConfig.NIGHTLY_BUILD || BuildConfig.DEBUG_BUILD; to DEBUG = BuildConfig.MOZILLA_OFFICIAL;
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jacheng
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8940976 -
Flags: review?(kikuo)
Assignee | ||
Comment 2•6 years ago
|
||
Currently, HLS support for Fennec will be phased into Beta59 not only on Nightly. Since this feature has become more stable now, we should stop printing the annoying log in official build.
Summary: [Fennec][HLS] Change HLS logging from BuildConfig.NIGHTLY_BUILD || BuildConfig.DEBUG_BUILD to BuildConfig.MOZILLA_OFFICIAL → [Fennec][HLS] Change HLS logging from BuildConfig.NIGHTLY_BUILD || BuildConfig.DEBUG_BUILD to !BuildConfig.MOZILLA_OFFICIAL
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8940976 [details] Bug 1420030 - Log HLS java side debug information only on non-release build Fennec. https://reviewboard.mozilla.org/r/211256/#review217064 looks good to me
Attachment #8940976 -
Flags: review?(kikuo) → review+
Pushed by jacheng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02b1c192fe2f Log HLS java side debug information only on non-release build Fennec. r=kikuo
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/02b1c192fe2f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•