Closed
Bug 1420056
Opened 7 years ago
Closed 7 years ago
MobileViewportManager and ZoomConstraintsClient constants clash due to unified build
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
MobileViewportManager.cpp and ZoomConstraintsClient.cpp define some identically named (and valued) static consts. This causes unified build bustage when they're both compiled together. The nsLiteralString constuctor is constexpr. I think we can just make these #defines to avoid the problem.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8931222 [details] Bug 1420056 - Use #defines for MobileViewportManager / ZoomConstraintsClient constants. https://reviewboard.mozilla.org/r/202332/#review207802
Attachment #8931222 -
Flags: review?(bugmail) → review+
|
||
Comment 3•7 years ago
|
||
Couldn't this be fixed without macros by declaring the constants in a header included by both files, and defininig them in one of the files?
|
Assignee | |
Comment 4•7 years ago
|
||
That would work too.
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7d3d822085c7 Use #defines for MobileViewportManager / ZoomConstraintsClient constants. r=kats
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7d3d822085c7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•