Closed Bug 1420056 Opened 4 years ago Closed 4 years ago
Viewport Manager and Zoom Constraints Client constants clash due to unified build
59 bytes, text/x-review-board-request
MobileViewportManager.cpp and ZoomConstraintsClient.cpp define some identically named (and valued) static consts. This causes unified build bustage when they're both compiled together. The nsLiteralString constuctor is constexpr. I think we can just make these #defines to avoid the problem.
Comment on attachment 8931222 [details] Bug 1420056 - Use #defines for MobileViewportManager / ZoomConstraintsClient constants. https://reviewboard.mozilla.org/r/202332/#review207802
Attachment #8931222 - Flags: review?(bugmail) → review+
Couldn't this be fixed without macros by declaring the constants in a header included by both files, and defininig them in one of the files?
That would work too.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/7d3d822085c7 Use #defines for MobileViewportManager / ZoomConstraintsClient constants. r=kats
You need to log in before you can comment on or make changes to this bug.