1420113 - move nsCSSFontFaceRule and nsCSSCounterStyle rule definitions out of nsCSSRules.cpp

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Cameron McCormack (:heycam)]

I want to stop compiling nsCSSRules.cpp as part of disabling the old style system, but we still use these two rules that are defined in there.  Let's split them out.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1420113 - Part 1: Move nsCSSCounterStyleRule to its own file.

Review commit: https://reviewboard.mozilla.org/r/202438/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202438/

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1420113 - Part 2: Move nsCSSFontFaceRule to its own file.

Review commit: https://reviewboard.mozilla.org/r/202440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202440/

Comment 3

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8002b2cb008555b2f3b2d9aa18e76545c3b80e30

Comment 4

[Code Review Bot [:reviewbot]]

Comment on attachment 8931288 [details]
Bug 1420113 - Part 1: Move nsCSSCounterStyleRule to its own file.

https://reviewboard.mozilla.org/r/202438/#review207776


C/C++ static analysis found 1 defect in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`


::: layout/style/nsCSSCounterStyleRule.cpp:30
(Diff revision 1)
> +  for (size_t i = 0; i < ArrayLength(mValues); ++i) {
> +    mValues[i] = aCopy.mValues[i];
> +  }
> +}
> +
> +nsCSSCounterStyleRule::~nsCSSCounterStyleRule()

Warning: Use '= default' to define a trivial destructor [clang-tidy: modernize-use-equals-default]

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8931288 [details]
Bug 1420113 - Part 1: Move nsCSSCounterStyleRule to its own file.

https://reviewboard.mozilla.org/r/202438/#review207838

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8931289 [details]
Bug 1420113 - Part 2: Move nsCSSFontFaceRule to its own file.

https://reviewboard.mozilla.org/r/202440/#review207844

Comment 7

[Cameron McCormack (:heycam)]

Comment on attachment 8931289 [details]
Bug 1420113 - Part 2: Move nsCSSFontFaceRule to its own file.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202440/diff/1-2/

Comment 8

[Code Review Bot [:reviewbot]]

Comment on attachment 8931288 [details]
Bug 1420113 - Part 1: Move nsCSSCounterStyleRule to its own file.

https://reviewboard.mozilla.org/r/202438/#review207952


C/C++ static analysis found 1 defect in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`


::: layout/style/nsCSSCounterStyleRule.cpp:30
(Diff revision 1)
> +  for (size_t i = 0; i < ArrayLength(mValues); ++i) {
> +    mValues[i] = aCopy.mValues[i];
> +  }
> +}
> +
> +nsCSSCounterStyleRule::~nsCSSCounterStyleRule()

Warning: Use '= default' to define a trivial destructor [clang-tidy: modernize-use-equals-default]

Comment 9

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=01b4ae2c84c8bbacaa670c4ace4c1b4a6ae6d122

Comment 10

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 6385260f99fe -d d140f71aa8f4: rebasing 435663:6385260f99fe "Bug 1420113 - Part 1: Move nsCSSCounterStyleRule to its own file. r=xidorn"
merging layout/style/nsCSSRules.cpp
rebasing 435664:af855207718d "Bug 1420113 - Part 2: Move nsCSSFontFaceRule to its own file. r=xidorn" (tip)
merging layout/style/nsCSSRules.cpp
merging layout/style/nsStyleUtil.cpp
warning: conflicts while merging layout/style/nsCSSRules.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 11

[Cameron McCormack (:heycam)]

Comment on attachment 8931288 [details]
Bug 1420113 - Part 1: Move nsCSSCounterStyleRule to its own file.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202438/diff/1-2/

Comment 12

[Cameron McCormack (:heycam)]

Comment on attachment 8931289 [details]
Bug 1420113 - Part 2: Move nsCSSFontFaceRule to its own file.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202440/diff/2-3/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2981c85f9586
Part 1: Move nsCSSCounterStyleRule to its own file. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/143968ef88f8
Part 2: Move nsCSSFontFaceRule to its own file. r=xidorn

Comment 14

[Code Review Bot [:reviewbot]]

Comment on attachment 8931288 [details]
Bug 1420113 - Part 1: Move nsCSSCounterStyleRule to its own file.

https://reviewboard.mozilla.org/r/202438/#review208076


C/C++ static analysis found 1 defect in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`


::: layout/style/nsCSSCounterStyleRule.cpp:30
(Diff revision 2)
> +  for (size_t i = 0; i < ArrayLength(mValues); ++i) {
> +    mValues[i] = aCopy.mValues[i];
> +  }
> +}
> +
> +nsCSSCounterStyleRule::~nsCSSCounterStyleRule()

Warning: Use '= default' to define a trivial destructor [clang-tidy: modernize-use-equals-default]

Comment 15

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2981c85f9586
https://hg.mozilla.org/mozilla-central/rev/143968ef88f8