Closed Bug 1420113 Opened 3 years ago Closed 3 years ago

move nsCSSFontFaceRule and nsCSSCounterStyle rule definitions out of nsCSSRules.cpp

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(2 files)

I want to stop compiling nsCSSRules.cpp as part of disabling the old style system, but we still use these two rules that are defined in there.  Let's split them out.
Blocks: 1420117
Comment on attachment 8931288 [details]
Bug 1420113 - Part 1: Move nsCSSCounterStyleRule to its own file.

https://reviewboard.mozilla.org/r/202438/#review207776


C/C++ static analysis found 1 defect in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`


::: layout/style/nsCSSCounterStyleRule.cpp:30
(Diff revision 1)
> +  for (size_t i = 0; i < ArrayLength(mValues); ++i) {
> +    mValues[i] = aCopy.mValues[i];
> +  }
> +}
> +
> +nsCSSCounterStyleRule::~nsCSSCounterStyleRule()

Warning: Use '= default' to define a trivial destructor [clang-tidy: modernize-use-equals-default]
Comment on attachment 8931288 [details]
Bug 1420113 - Part 1: Move nsCSSCounterStyleRule to its own file.

https://reviewboard.mozilla.org/r/202438/#review207838
Attachment #8931288 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8931289 [details]
Bug 1420113 - Part 2: Move nsCSSFontFaceRule to its own file.

https://reviewboard.mozilla.org/r/202440/#review207844
Attachment #8931289 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8931288 [details]
Bug 1420113 - Part 1: Move nsCSSCounterStyleRule to its own file.

https://reviewboard.mozilla.org/r/202438/#review207952


C/C++ static analysis found 1 defect in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`


::: layout/style/nsCSSCounterStyleRule.cpp:30
(Diff revision 1)
> +  for (size_t i = 0; i < ArrayLength(mValues); ++i) {
> +    mValues[i] = aCopy.mValues[i];
> +  }
> +}
> +
> +nsCSSCounterStyleRule::~nsCSSCounterStyleRule()

Warning: Use '= default' to define a trivial destructor [clang-tidy: modernize-use-equals-default]
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 6385260f99fe -d d140f71aa8f4: rebasing 435663:6385260f99fe "Bug 1420113 - Part 1: Move nsCSSCounterStyleRule to its own file. r=xidorn"
merging layout/style/nsCSSRules.cpp
rebasing 435664:af855207718d "Bug 1420113 - Part 2: Move nsCSSFontFaceRule to its own file. r=xidorn" (tip)
merging layout/style/nsCSSRules.cpp
merging layout/style/nsStyleUtil.cpp
warning: conflicts while merging layout/style/nsCSSRules.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2981c85f9586
Part 1: Move nsCSSCounterStyleRule to its own file. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/143968ef88f8
Part 2: Move nsCSSFontFaceRule to its own file. r=xidorn
Comment on attachment 8931288 [details]
Bug 1420113 - Part 1: Move nsCSSCounterStyleRule to its own file.

https://reviewboard.mozilla.org/r/202438/#review208076


C/C++ static analysis found 1 defect in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`


::: layout/style/nsCSSCounterStyleRule.cpp:30
(Diff revision 2)
> +  for (size_t i = 0; i < ArrayLength(mValues); ++i) {
> +    mValues[i] = aCopy.mValues[i];
> +  }
> +}
> +
> +nsCSSCounterStyleRule::~nsCSSCounterStyleRule()

Warning: Use '= default' to define a trivial destructor [clang-tidy: modernize-use-equals-default]
https://hg.mozilla.org/mozilla-central/rev/2981c85f9586
https://hg.mozilla.org/mozilla-central/rev/143968ef88f8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.