1420192 - Youtube and twitch.com live videos don't work when auto-play is off

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[Oana Horvath [:ohorvath]]

Devices:
Huawei P9 Lite (Android 6.0)
Huawei Honor 8 (Android 7.0)
Lenovo Yoga Tablet 2 (Android 4.4.2)

Build: Nightly 59.0a1 (2017-11-23);

Steps to reproduce:
1. Go to Settings>Advanced and turn off Media auto-play.
2. Open a youtube video and tap play.
3. Go to twitch.tv and open a live video and tap play.

Expected result:
The videos should start playing.

Actual result:
The videos can't be played when auto-play is off.

Note: reproducing with any youtube video live or recorded.
Other video websites as: vimeo, nytimes, or adultswim.com (live stream) are working.

Comment 1

[John Lin [:jhlin][:jolin]]

Alaster, could you please help check this one? Thanks.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1420192 - when disable autoplay, allow script calls play() once user triggered load() or seek().

This patch is mainly reverting the changing of bug1382574 part3, but not all the same.

Since youtube would call load() when user clicks to play, and then call play()
later. For the old pref (checking user-input-play), we should still allow the
following play() even it's not triggered via user input. It's also same for
seeking, Youtube would call play() after seeking completed.

In this patch, we would allow the script-calling once play() if user has called load()
or seek() before that.

Review commit: https://reviewboard.mozilla.org/r/202744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202744/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8931604 [details]
Bug 1420192 - when disable autoplay, allow script calls play() once user triggered load() or seek().

https://reviewboard.mozilla.org/r/202744/#review208068

Comment 4

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfc785d46e7e5e8ca27e0d55b50003319264f714

Comment 5

[Alastor Wu [:alwu]]

Comment on attachment 8931604 [details]
Bug 1420192 - when disable autoplay, allow script calls play() once user triggered load() or seek().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202744/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/413ed7bee307
when disable autoplay, allow script calls play() once user triggered load() or seek(). r=jwwang

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/413ed7bee307

Comment 8

[Bogdan Surd, QA [:bsurd, NI]]

Attachment: log.txt

Tested this on a Samsung Galaxy Tab S3 (Android 7.0) & Nexus 6P (Android 8.0) everything works fine on YouTube but the issue is still reproducible for twitch.tv, reopening the issue.

Comment 9

[Oana Horvath [:ohorvath]]

The issue with twitch.tv is reproducing on Beta 58 too, so it's not related to the HLS feature. There's also Bug 1377891 that seems to describe the same behavior. Will keep that one open and I'll mark this one as fixed.