1420375 - During navigation, carry the user-activation flag of present document to a new document if they're in the same eTLD

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Alastor Wu [:alwu]]

In bug1415444, we implemented the flag which stores whether user has activated the document by specific user gestures. When navigating to new document, the flag should be carried if the new document has same eTLD+1. 

One example is, 
1. User login on siteA (user activates siteA)
2. site automatically jump to another siteB after login success (siteB is not activated yet)

For siteB, we should still regard it as activated, to keep the broswering experience consistent.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1420375 - propagate user-activation flag to new document with same eTLD.

In autoplay policy, we want to keep user experience consistent during navigation.

If user has played media on one site, and then navigate to another site which has same
eTLD, then we want it could also be allowed to autoplay.

Therefore, we need to propagate the user-activation flag from old document to new document.

Review commit: https://reviewboard.mozilla.org/r/203864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203864/

Comment 2

[Alastor Wu [:alwu]]

Comment on attachment 8932820 [details]
Bug 1420375 - propagate user-activation flag to new document with same eTLD.

Hi, smaug,
I'm not sure whether this is a proper way, could you give me some feedback?
(I'll also add a test later)
Thanks!

Comment 3

[Olli Pettay [:smaug][[e-mail]](vacation until July 14)]

Comment on attachment 8932820 [details]
Bug 1420375 - propagate user-activation flag to new document with same eTLD.

https://reviewboard.mozilla.org/r/203864/#review210612

::: docshell/base/nsDocShell.cpp:8404
(Diff revision 1)
> +  if (!aOldDoc->HasBeenUserActivated()) {
> +    return;
> +  }
> +
> +  // make sure the URL of both documents are in the same eTLD
> +  if (!nsContentUtils::IsSameBaseDomain(aOldDoc->GetDocumentURI(),

Comparing document uris isn't quite right. One could navigate to an about:blank or data:url or such, yet the domain would stay the same. You probably want to compare the URIs of the documents' principal

Comment 4

[Olli Pettay [:smaug][[e-mail]](vacation until July 14)]

Comment on attachment 8932820 [details]
Bug 1420375 - propagate user-activation flag to new document with same eTLD.

And this kind of feature needs quite a few tests.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1420375 - propagate user-activation flag to new document with same eTLD.

In autoplay policy, we want to keep user experience consistent during navigation.

If user has played media on one site, and then navigate to another site which has same
eTLD, then we want it could also be allowed to autoplay.

Therefore, we need to propagate the user-activation flag from old document to new document.

Review commit: https://reviewboard.mozilla.org/r/213528/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213528/

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1420375 - part 2 : add test.

Review commit: https://reviewboard.mozilla.org/r/213530/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213530/

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

We decided to not do this.