Closed
Bug 1420379
Opened 7 years ago
Closed 7 years ago
move css::Rule implementation to its own file
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
Ah, like nsCSSFontFaceRule and nsCSSCounterStyleRule, we need css::Rule to live in its own file so we can keep it once we've disabled the old style system.
|
Assignee | |
Comment 1•7 years ago
|
||
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8931644 [details]
Bug 1420379 - Move css::Rule into its own file.
https://reviewboard.mozilla.org/r/202812/#review208170
::: layout/style/Rule.cpp:11
(Diff revision 1)
> +
> +/* base class for all rule types in a CSS style sheet */
> +
> +#include "Rule.h"
> +
> +#include "mozilla/css/GroupRule.h"
Why GroupRule.h? I think Rule.h should be enough?
Attachment #8931644 -
Flags: review?(xidorn+moz) → review+
|
||
Updated•7 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 4•7 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8931644 [details]
Bug 1420379 - Move css::Rule into its own file.
https://reviewboard.mozilla.org/r/202812/#review208170
> Why GroupRule.h? I think Rule.h should be enough?
Oh, it's because e.g. GetParentRule() needs to know that GroupRule inherits from Rule.
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f515d752e17f
Move css::Rule into its own file. r=xidorn
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•