Closed
Bug 1420383
Opened 7 years ago
Closed 7 years ago
move nsCSSProps::kParserVariantTable definition out of nsCSSParser.cpp
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
No description provided.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8931646 [details]
Bug 1420383 - Move nsCSSProps::kParserVariantTable into its rightful home in nsCSSProps.cpp.
https://reviewboard.mozilla.org/r/202816/#review208172
So the table was introduced in bug 636029, and at that time, the `VARIANT_` constants are in `nsCSSParser.cpp`, so the table has to live there. Later, those constants are moved to `nsCSSProps.h` in bug 877690, so the table no longer needs to stay there anymore. Good.
Attachment #8931646 -
Flags: review?(xidorn+moz) → review+
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → cam
Status: NEW → ASSIGNED
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52f101155bac
Move nsCSSProps::kParserVariantTable into its rightful home in nsCSSProps.cpp. r=xidorn
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•