1420593 - Refactor browser/components/preferences/in-content/tests/browser_cookies_exceptions.js

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tooru Fujisawa [:arai]]

Related to bug 1414180, this test needs to be fixed regarding the change in bug 1193394.
before that, I'd like to refactor this test to make it easier to fix it.
currently this test uses promise with callback, and in some place it's abusing the wait or the original structure.
I'm going to rewrite this with async/await.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Refactor browser/components/preferences/in-content/tests/browser_cookies_exceptions.js

This was necessary to investigate the issue fixed in bug 1421118.
actually this modification might be overkill,
but I think now the test is more easy to understand once some test fails
(since there's no loop, no numbering, etc)

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8932824 [details] [diff] [review]
Refactor browser/components/preferences/in-content/tests/browser_cookies_exceptions.js

Review of attachment 8932824 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/preferences/in-content/tests/browser_cookies_exceptions.js
@@ +1,5 @@
>  /* Any copyright is dedicated to the Public Domain.
>   * http://creativecommons.org/publicdomain/zero/1.0/ */
>  
>  requestLongerTimeout(2);
> +requestLongerTimeout(3);

Can you merge these two calls?

@@ +272,5 @@
> +  let observeAllPromise = createObserveAllPromise(observances);
> +
> +  await test(params, observeAllPromise, () => btnApplyChanges.doCommand());
> +
> +  gBrowser.removeCurrentTab();

Replace this with `await BrowserTestUtils.removeTab(gBrowser.selectedTab);`

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72e07dd3b573
Refactor browser/components/preferences/in-content/tests/browser_cookies_exceptions.js r=jaws

Comment 4

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72e07dd3b573d2c5f387338a8c83b7f996f2f0ff
Bug 1420593 - Refactor browser/components/preferences/in-content/tests/browser_cookies_exceptions.js r=jaws

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/72e07dd3b573