1420797 - Add GMPLibraryPath to Super Search Fields

Status: RESOLVED FIXED

(Socorro :: General, task, P2)

Description

[James Cheng[:JamesCheng]]

Bug 1416686 will be landed soon and it adds a 

CrashReporter::AnnotateCrashReport(NS_LITERAL_CSTRING("GMPLibraryPath"),...);

I would like to request adding this private field into Socorro.

Comment 1

[James Cheng[:JamesCheng]]

Hi willkg,

Would you please help on this?

Thanks.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

What's the urgency for this? Is it something you need added today? Sometime this quarter? Or is this a nice-to-have?

Comment 3

[James Cheng[:JamesCheng]]

It's not urgent. I think this is a nice-to-have.

I'm not familiar with Socorro, I just want to make sure the record that I use AnnotateCrashReport to log will be shown in Socorro at some private field that I can see.

Thanks.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Ok. I'll mark it as a P2 and we'll get to it when we get to it. Thanks!

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Here's an example crash with it:

https://crash-stats.mozilla.com/report/index/77745e3f-59a1-4ab0-a4b9-7a2bd0180912#tab-metadata

It's already hidden from public view. I'm adding it as a super search field that requires PII access.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4591: fix bug 1490662, 1420797, 1467856: add fields to super search

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/f549d6e5d3edfa037a7df638ec2ea727da7498cf
fix bug 1420797: add gmp_library_path to super search fields

The field has values which have file system paths in them, so we need to
consider it PII. I exposed it as a filter as a string, but I'm not sure
anyone would ever want to search using it.

https://github.com/mozilla-services/socorro/commit/39964ca7144f28c177928a80b07e6f798f137229
Merge pull request #4591 from willkg/1490662-memoryerrorcorrection

fix bug 1490662, 1420797, 1467856: add fields to super search