1490662 - add MemoryErrorCorrection to supersearch interface

Status: RESOLVED FIXED

(Socorro :: General, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bug #1489297 added MemoryErrorCorrection to the crash reports. We want to:

1. add that to super search so that it's searchable and facetable and all that
2. add it to the report index page

This bug covers that.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P2. I'll try to get to this soon.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4591: fix bug 1490662, 1420797, 1467856: add fields to super search

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/0158307c62e23558fa6224c34c66020b3d1648a6
bug 1490662: add MemoryErrorCorrection to super search

This adds MemoryErrorCorrection to super search.

The values are probably well-defined so we can additionally constrain
them which will make it easier for people searching for specific values.
Once we accrue enough data, we can do the constraining then.

https://github.com/mozilla-services/socorro/commit/39964ca7144f28c177928a80b07e6f798f137229
Merge pull request #4591 from willkg/1490662-memoryerrorcorrection

fix bug 1490662, 1420797, 1467856: add fields to super search

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

For what it's worth, there are 9 possible strings that the code could report.  From:

https://searchfox.org/mozilla-central/rev/de7676288a78b70d2b9927c79493adbf294faad5/toolkit/xre/nsAppRunner.cpp#3712-3721

  "Reserved"
  "Other"
  "Unknown"
  "None"
  "Parity"
  "Single-bit ECC"
  "Multi-bit ECC"
  "CRC"

and then from https://searchfox.org/mozilla-central/rev/de7676288a78b70d2b9927c79493adbf294faad5/toolkit/xre/nsAppRunner.cpp#3772

  "Unexpected value"

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Oh, that's super helpful. I'll fix the super search form.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/39dbd63774da49ee61d899ae66f1653e8c3ea8f1
fix bug 1490622: add values for memory_error_correction

https://github.com/mozilla-services/socorro/commit/513f104e8fca04a92bdc158d93749320631f1c21
Merge pull request #4592 from willkg/1490662-memoryerrorcorrection-values

fix bug 1490622: add values for memory_error_correction

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

ES indexes get created on Sundays. If data comes in for which there's no indexing instructions, it gets indexed in a certain way. In this particular case, it's unhelpful. So faceting on this field is a bunch of junk and searching won't work.

So, this landed and is on stage, but won't work until next week when a new index is created. When we push this to prod, we'll have the same situation.