[Pantheon (elemenaryOS)] Titlebar is shown despite settings to draw in the titlebar

RESOLVED FIXED in Firefox 59

Status

()

defect
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

(Blocks 1 bug)

Trunk
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

a year ago
Hi,
despite enabling CSD (customize / Title Bar [x]), the CSD titlebar is not shown on Pantheon (elemenaryOS) aswell.

echo $XDG_CURRENT_DESKTOP
Pantheon
(Assignee)

Comment 1

a year ago
Can you please run latest trunk and check what settings do work for you? Set browser.tabs.drawInTitlebar to true at about:config and run:

$MOZ_GTK_TITLEBAR_DECORATION=client firefox
$MOZ_GTK_TITLEBAR_DECORATION=system firefox

Thanks.
Flags: needinfo?(christian.ohrfandl)
(Assignee)

Comment 2

a year ago
(In reply to Martin Stránský [:stransky] from comment #1)
> Can you please run latest trunk and check what settings do work for you? Set
> browser.tabs.drawInTitlebar to true at about:config and run:
> 
> $MOZ_GTK_TITLEBAR_DECORATION=client firefox
> $MOZ_GTK_TITLEBAR_DECORATION=system firefox
> 
> Thanks.

err, by "firefox" I mean your nightly build which means you should call it by "./firefox" or so.
Will do on Friday, when I am back on my elementary PC.
Flags: needinfo?(christian.ohrfandl)
So, just tested with firefox-trunk (59.0a1 (2017-12-05) (64-bit))

> MOZ_GTK_TITLEBAR_DECORATION=client firefox-trunk
> MOZ_GTK_TITLEBAR_DECORATION=system firefox-trunk

Both versions work "the same" (c.f. picture).

However I am facing the following problems aswell:
- Double click on the top bar does not maximize/unmaximize firefox
- Header bar seems to only use the systems them for this narrow area above the "tab-row"; the tab-row uses just grey (I guess it should use the system theme aswell)
- Global window button arrangement (defined systemwide) seems to be ignored (they should be on the left)
- Window buttons are only visible if "Default" theme is selected (c.f. Customize...)
Flags: needinfo?(stransky)
(Assignee)

Updated

a year ago
Blocks: gtktitlebar
No longer blocks: 1417933
(Assignee)

Comment 6

a year ago
Thanks, looks like we can enable system decoration mode for Pantheon then.
(Assignee)

Updated

a year ago
Depends on: 1417933

Comment 8

a year ago
mozreview-review
Comment on attachment 8942073 [details]
Bug 1420818 - For rendering to titlebar make CSD window decorations mode default, enable WM decorations on Elementary OS,

https://reviewboard.mozilla.org/r/212290/#review218784
Attachment #8942073 - Flags: review?(jhorak) → review+

Comment 9

a year ago
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/8dee5d879ef1
For rendering to titlebar make CSD window decorations mode default, enable WM decorations on Elementary OS, r=jhorak

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8dee5d879ef1
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.