1420818 - [Pantheon (elemenaryOS)] Titlebar is shown despite settings to draw in the titlebar

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Hi,
despite enabling CSD (customize / Title Bar [x]), the CSD titlebar is not shown on Pantheon (elemenaryOS) aswell.

echo $XDG_CURRENT_DESKTOP
Pantheon

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Can you please run latest trunk and check what settings do work for you? Set browser.tabs.drawInTitlebar to true at about:config and run:

$MOZ_GTK_TITLEBAR_DECORATION=client firefox
$MOZ_GTK_TITLEBAR_DECORATION=system firefox

Thanks.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

(In reply to Martin Stránský [:stransky] from comment #1)
> Can you please run latest trunk and check what settings do work for you? Set
> browser.tabs.drawInTitlebar to true at about:config and run:
> 
> $MOZ_GTK_TITLEBAR_DECORATION=client firefox
> $MOZ_GTK_TITLEBAR_DECORATION=system firefox
> 
> Thanks.

err, by "firefox" I mean your nightly build which means you should call it by "./firefox" or so.

Comment 3

[christian.ohrfandl]

Will do on Friday, when I am back on my elementary PC.

Comment 4

[christian.ohrfandl]

So, just tested with firefox-trunk (59.0a1 (2017-12-05) (64-bit))

> MOZ_GTK_TITLEBAR_DECORATION=client firefox-trunk
> MOZ_GTK_TITLEBAR_DECORATION=system firefox-trunk

Both versions work "the same" (c.f. picture).

However I am facing the following problems aswell:
- Double click on the top bar does not maximize/unmaximize firefox
- Header bar seems to only use the systems them for this narrow area above the "tab-row"; the tab-row uses just grey (I guess it should use the system theme aswell)
- Global window button arrangement (defined systemwide) seems to be ignored (they should be on the left)
- Window buttons are only visible if "Default" theme is selected (c.f. Customize...)

Comment 5

[christian.ohrfandl]

Attachment: firefox-trunk with MOZ_GTK_TITLEBAR_DECORATION={client, system}

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Thanks, looks like we can enable system decoration mode for Pantheon then.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1420818 - For rendering to titlebar make CSD window decorations mode default, enable WM decorations on Elementary OS,

Review commit: https://reviewboard.mozilla.org/r/212290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212290/

Comment 8

[Jan Horak [:jhorak]]

Comment on attachment 8942073 [details]
Bug 1420818 - For rendering to titlebar make CSD window decorations mode default, enable WM decorations on Elementary OS,

https://reviewboard.mozilla.org/r/212290/#review218784

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dee5d879ef1
For rendering to titlebar make CSD window decorations mode default, enable WM decorations on Elementary OS, r=jhorak

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8dee5d879ef1